Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code to investigate #81

Open
irevoire opened this issue Jul 3, 2024 · 0 comments · May be fixed by #93
Open

Dead code to investigate #81

irevoire opened this issue Jul 3, 2024 · 0 comments · May be fixed by #93

Comments

@irevoire
Copy link
Member

irevoire commented Jul 3, 2024

Hey,

I noticed some dead code in the euclidean & manhattan distance;

normal.header.bias = normal
.vector
.iter()
.zip(node_p.vector.iter())
.zip(node_q.vector.iter())
.map(|((n, p), q)| -n * (p + q) / 2.0)
.sum();

normal.header.bias = normal
.vector
.iter()
.zip(node_p.vector.iter())
.zip(node_q.vector.iter())
.map(|((n, p), q)| -n * (p + q) / 2.0)
.sum();

Before deleting it, we should investigate and try to understand if we were not supposed to be doing this operation in the pre-process or somewhere else?
Are the bias even set anywhere?

@irevoire irevoire linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant