Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the bias as intended #93

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #81

What does this PR do?

  • After looking into annoy it looks like we ignored the bias for the euclidean and manhattan distance, but using the bias the recall improved a little bit on small dimension datasets:
    On main:
    image
    After this PR:
    image

![WARNING]
Currently, this doesn't apply to the angular distance, we need to read the annoy code further to understand what they’re doing with the norm and if we’re doing everything correctly

And for the binary quantization?

Currently, I don't really know how we should implements that for the binary quantization. I did a few tests here and some improved the recall sometimes for almost 10 points:
image

@irevoire irevoire added enhancement New feature or request tech exploration Explore technical domains indexing Everything related to indexing relevancy db-breaking labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db-breaking enhancement New feature or request indexing Everything related to indexing relevancy tech exploration Explore technical domains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead code to investigate
1 participant