Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13: Code sample tracker #3133

Open
guimachiavelli opened this issue Jan 28, 2025 · 12 comments
Open

v1.13: Code sample tracker #3133

guimachiavelli opened this issue Jan 28, 2025 · 12 comments
Milestone

Comments

@guimachiavelli
Copy link
Member

No description provided.

@guimachiavelli guimachiavelli added this to the v1.13 milestone Jan 28, 2025
@guimachiavelli
Copy link
Member Author

guimachiavelli commented Feb 4, 2025

#3144 — Remote federated search

  • NEW: multi_search_remote_federated_1
  • NEW: get_network_1
  • NEW: update_network_1

@curquiza
Copy link
Member

curquiza commented Feb 5, 2025

@guimachiavelli do you know if you add new code samples because of AI stabilization?

@guimachiavelli
Copy link
Member Author

At the moment, no. I'm doing a final pass on that PR today and will update this issue when I have a definitive answer.

@guimachiavelli
Copy link
Member Author

guimachiavelli commented Feb 5, 2025

#3137 — AI-powered search changes

I have updated the placeholder values of the following code samples:

  • UPDATE: update_embedders_1
  • UPDATE: search_parameter_guide_hybrid_1
  • UPDATE: search_parameter_guide_vector_1
  • UPDATE: search_parameter_reference_retrieve_vectors_1
  • UPDATE: get_all_batches_1
  • UPDATE: get_batch_1

@curquiza, these are only making placeholder naming a bit more consistent across our code samples.

@curquiza
Copy link
Member

curquiza commented Feb 5, 2025

@guimachiavelli there is no update on get_all_batches_1 because it's only the host URL, something you already have merged in another PR (#3083). It's the a little bit confusing here. Can you put only the ones that really changed, not the missing one from localhost changes?

Same for search_parameter_guide_hybrid_1 search_parameter_guide_vector_1 search_parameter_reference_retrieve_vectors_1

Integration team hasn't had the time to update code samples with the new MEILISEARCH_URL anyway

@guimachiavelli
Copy link
Member Author

MEILISEARCH_URL and using the correct placeholder format for the OpenAI API key are the only code sample changes for AI search in v1.13. There are no other changes.

If none of these are relevant to the integrations team, I can update my previous comment so it states there are no changes that impact you.

@curquiza
Copy link
Member

curquiza commented Feb 5, 2025

  • UPDATE: update_embedders_1

  • UPDATE: reset_embedders_1

  • UPDATE: search_parameter_guide_hybrid_1

  • UPDATE: search_parameter_guide_vector_1

  • UPDATE: search_parameter_reference_retrieve_vectors_1

  • UPDATE: get_all_batches_1

  • UPDATE: get_batch_1

update_embedders_1 -> yes, format impacts integration
reset_embedders_1 -> I don't see any change in your PR
search_parameter_guide_hybrid_1, search_parameter_guide_vector_1, search_parameter_reference_retrieve_vectors_1, get_all_batches_1 get_batch_1 -> no impact

@guimachiavelli
Copy link
Member Author

You are right. I crossed out the ones that have no impact for you and removed reset_embedders_1.

@guimachiavelli
Copy link
Member Author

#3138 — Dumpless upgrades

No code sample updates.

@guimachiavelli
Copy link
Member Author

This is the final list of code samples updates for v1.13, @meilisearch/integration-team

@Strift
Copy link
Contributor

Strift commented Feb 11, 2025

After discussion @curquiza, we agreed the only code sample I need to work on is: update_embedders_1

  • In PHP
  • In JavaScript
  • Other SDKs (only if the code sample exists)

Please let me know if this is incorrect.

@Strift Strift self-assigned this Feb 11, 2025
@Strift
Copy link
Contributor

Strift commented Feb 13, 2025

@Strift Strift removed their assignment Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants