Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_search_federated_1 code sample missing from most integrations #313

Open
ellnix opened this issue Jan 19, 2025 · 1 comment
Open

multi_search_federated_1 code sample missing from most integrations #313

ellnix opened this issue Jan 19, 2025 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@ellnix
Copy link

ellnix commented Jan 19, 2025

There's a multi_search_federated_1 code sample:
Live website: https://www.meilisearch.com/docs/reference/api/multi_search#federated-multi-search
meilisearch-js: https://github.com/meilisearch/meilisearch-js/blob/489b58351c568e30a6c336d6e8bc9a603f17543d/.code-samples.meilisearch.yaml#L784

multi_search_federated_1: |-
  client.multiSearch({
    federation: {},
    queries: [
      {
        indexUid: 'movies',
        q: 'batman',
      },
      {
        indexUid: 'comics',
        q: 'batman',
      },
    ]
  })

It seems to be only implemented in js and php, likely because instructions to add it were missing from the issues created from #302 (see meilisearch/meilisearch-go#573 as a sample)

@ellnix ellnix changed the title Add multi_search_federated_1 code sample to all integrations multi_search_federated_1 code sample missing from most integrations Jan 19, 2025
@curquiza
Copy link
Member

Hello @ellnix
thanks for the report
I guess this is not the only code samples that is missing, we do our best but we have some misses sometimes
We have an internal tool to report all the missing code samples. I will try to run it when I will have more time, and I will open an issue with all missing code samples. In the meantime, I let this issue open 😉

@curquiza curquiza added the documentation Improvements or additions to documentation label Jan 20, 2025
meili-bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Jan 23, 2025
1064: Add federated search code-sample r=sanders41 a=ellnix

There is a code sample at https://www.meilisearch.com/docs/reference/api/multi_search#federated-multi-search which most integrations don't seem to have.

Noticed this today and reported on integration-guides: meilisearch/integration-guides#313

Co-authored-by: ellnix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants