Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build along a "reference build" #40

Open
thibaultduponchelle opened this issue Jan 4, 2021 · 4 comments
Open

Build along a "reference build" #40

thibaultduponchelle opened this issue Jan 4, 2021 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@thibaultduponchelle
Copy link
Contributor

thibaultduponchelle commented Jan 4, 2021

For instance when rebuilding a failed build, I would like to rebuild the "reference OK" build : means the last one that was green.
We won't be able to do this completely, because inputs are maybe not available (commit or deps) but we could at least try to emulate some parts : the sparrowfile and sparky.yaml and therefore, as it is inside these files, the docker image and/or host target (but not its state of course).

It requires to store this "last OK config" somehow (versioning ? db ?).

It's not 100% clear in my mind and it's a nice to have, but I really think it has great added value for end user.

On end user side, I would like to have an option to start 2 builds at the same time, one behing the reference and the other the current.

Should play well with #32 😀

@thibaultduponchelle thibaultduponchelle changed the title Build along reference build Build along a "reference build" Jan 4, 2021
@melezhik
Copy link
Owner

melezhik commented Jan 4, 2021

I see. One comment. Technically it's possible to find the last successful build and rebuild it. Why do you need an explicit link/button for that?

@melezhik melezhik self-assigned this Jan 4, 2021
@melezhik melezhik added the question Further information is requested label Jan 4, 2021
@thibaultduponchelle
Copy link
Contributor Author

I would say yes, but since it will just start 2 individual builds, it's not perfect. I would like to have somewhat like a link between them (for the launch and the analysis), but don't know exactly on which form (yet).

@melezhik
Copy link
Owner

It requires to store this "last OK config" somehow (versioning ? db ?).

btw some of this information is already stored - https://github.com/melezhik/sparky/blob/master/bin/sparky-runner.raku#L53

And this is how rebuild works - https://github.com/melezhik/sparky/blob/master/bin/sparky-web.raku#L33

@melezhik
Copy link
Owner

On end user side, I would like to have an option to start 2 builds at the same time, one behing the reference and the other the current.

I do understand the idea, I am not sure if we can make a really clear UX on that ... Right now like I said we at least can find the last successful build and rebuild it. Maybe we can think of last successful build / last build / rebuild last successful build / links on project page as a simple start ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants