Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash.merge to 4.6.2 to resolve security vulnerability #18

Open
meszaros-lajos-gyorgy opened this issue Jul 17, 2019 · 7 comments

Comments

@meszaros-lajos-gyorgy
Copy link

Hi!

The guys at npm found a security vulnerability with lodash, which was fixed in 4.6.2:

image

@mcandre
Copy link

mcandre commented Jul 18, 2019

Last commit was in 2017. This project is dead as dirt. Go ahead and fork it, publish a new package name on NPM.

@meszaros-lajos-gyorgy
Copy link
Author

Linking pull request, which would solve this issue: #17

@meszaros-lajos-gyorgy
Copy link
Author

meszaros-lajos-gyorgy commented Jul 19, 2019

@mcandre: Well, the author's last activity was in early april this year, so I assume you are right. I do prefer to wait a bit more to see if the author checks github.
Also, there are already 11 forks of the repo. Are there any candidates for the replacement of the main repo?

@meszaros-lajos-gyorgy
Copy link
Author

I've checked all forks and most of them are either behind/even with master or contain dependency version updates. If someone is to publish a fork of this repo should also add the other pull request which checks for html validation failure. I'm happy to publish a fork of this, but what should be it's name? express-minify-html-2?

@meszaros-lajos-gyorgy
Copy link
Author

express-minify-html-2 is out live: https://www.npmjs.com/package/express-minify-html-2

@m-majetic
Copy link

Thanks for taking care of this and for putting the cat into the sock :)

@ryanlelek
Copy link

Thanks, helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants