Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: stream_name_splits toggle in targets #1319

Closed
visch opened this issue Jan 10, 2023 · 3 comments
Closed

Feature: stream_name_splits toggle in targets #1319

visch opened this issue Jan 10, 2023 · 3 comments

Comments

@visch
Copy link
Contributor

visch commented Jan 10, 2023

Feature scope

Targets (data type handling, batching, SQL object generation, etc.)

Description

For SQL Targets we splits streams based on dash's see https://github.com/meltano/sdk/blob/main/singer_sdk/sinks/sql.py#L67-L103 , this can be confusing for folks we aren't expecting this or who have a source like tap-dynamodb that have streams with dash's in the name by design, but the dash's do not represent <schema>-<table> . So I think we should add a flag for stream_name_splits

Example implementation here MeltanoLabs/target-postgres#59

Slack thread: https://meltano.slack.com/archives/C01TCRBBJD7/p1671688563297449

@visch visch added kind/Feature New feature or request valuestream/SDK labels Jan 10, 2023
@aaronsteers aaronsteers moved this to Up Next in Office Hours Jan 18, 2023
@aaronsteers aaronsteers changed the title [Feature]: stream_name_splits toggle Feature: stream_name_splits toggle in targets Jan 18, 2023
@aaronsteers aaronsteers moved this from Up Next to Discussed in Office Hours Jan 25, 2023
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

@stale stale bot removed the stale label Jul 21, 2023
Copy link

stale bot commented Jul 20, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 20, 2024
@stale stale bot closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants