Url pattern problem with hyphened domain names #158
Comments
|
@n00dl3 could you submit this as a pull request, so when @meltingice finally decides to actually deal with bug reports, it's a small task for them to fix this issue? |
prtksxna
added a commit
to prtksxna/CamanJS
that referenced
this issue
Apr 19, 2016
Code from @n00dl3's comment on the issue. Closes meltingice#158 Not sure whether build the files to JS, or if that is done during a release cut. Running `cake build` on `master` builds more changes than just this one, so I am unsure.
This was referenced Apr 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, we got a problem on a site with a domain name containing an hyphen, images were considered as other domain ones, line 1403 of caman.full.js v4.1.2
IO.domainRegex = /(?:(?:http|https):\/\/)((?:\w+)\.(?:(?:\w|\.)+))/;we had to replace it by
IO.domainRegex = /(?:(?:http|https):\/\/)((?:[a-zA-Z0-9_-]+)\.(?:(?:[a-zA-Z0-9_-]*|\.)+))/;which does the trick
edit:
Sorry, I put a wrong one as a fix
The text was updated successfully, but these errors were encountered: