Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Database Entities Not Utilized in Recall within #1991

Open
pihang opened this issue Oct 29, 2024 · 0 comments
Open

Graph Database Entities Not Utilized in Recall within #1991

pihang opened this issue Oct 29, 2024 · 0 comments
Assignees

Comments

@pihang
Copy link

pihang commented Oct 29, 2024

🐛 Describe the bug

memo/proxy/main.py
It seems that when answering questions in memo/proxy/main.py, the recall mechanism doesn't utilize the dictionary information from the graph database.

Current code:
memories_text = "\n".join(memory["memory"] for memory in relevant_memories["results"])

In memo/memory/main.py, the memory search actually includes parallel searches in both vector storage and graph storage. The code returns:
return {"results": original_memories, "relations": graph_entities}

However, here only original_memories from vector storage recall is handled, and the graph database entities (graph_entities) are not used in constructing the memory recall.

How should we handle the recall of entities from the graph database?

For instance, data structured as follows is not being utilized:
search_results.append({"source": item[0], "relationship": item[1], "target": item[2]})
Example:

{
  "memories": [...],
  "entities": [
    {"source": "peter", "relation": "identity", "destination": "spiderman"}
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants