Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Attach Sources #5

Open
blundell opened this issue Dec 30, 2013 · 6 comments
Open

Attach Sources #5

blundell opened this issue Dec 30, 2013 · 6 comments

Comments

@blundell
Copy link

Currently when I click through to the source, it asks me to attach them. (i.e. cmd+click on LoginButton).

Would be nice in the readme to add this to the gradle script, or update the AAR internally.

https://github.com/facebook/facebook-android-sdk

@mente
Copy link
Owner

mente commented Dec 30, 2013

What changes are you talking about? If automatic attach of the sources it depends on IDE you're using. If it's Android Studio there's no way to automatically attach sources in gradle script (known to me). IDEA automatically attaches sources if available.

@blundell
Copy link
Author

Ah ok, just before when I have done maven repo releases, you can also release the sources jar, therefore when you do "attach sources" it can look them up in the same repo location.

@mente
Copy link
Owner

mente commented Dec 30, 2013

Check #4, sources should be available

@mente
Copy link
Owner

mente commented Dec 30, 2013

Hm, looks like there were changes in Android Studio. I've verified working of sources with some 0.3.x version. With latest 0.4.0 sources are not available anymore. Not sure what can I do here.
Sources are working as expected. Just use example pom.xml to verify

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.mycompany.app</groupId>
  <artifactId>my-module</artifactId>
  <version>1</version>

  <repositories>
    <repository>
      <id>github-facebook</id>
      <name>Facebook github</name>
      <layout>default</layout>
      <url>http://mente.github.io/facebook-api-android-aar</url>
    </repository>
  </repositories>

  <dependencies>
    <dependency>
      <groupId>com.facebook</groupId>
      <artifactId>facebook-android-sdk</artifactId>
      <version>3.6.0</version>
      <type>aar</type>
    </dependency>
  </dependencies>
</project>

@blundell
Copy link
Author

Yeah I'm on 0.4.0 with Gradle 👍 good to know it's not just me

@mente
Copy link
Owner

mente commented Dec 30, 2013

I've posted the question to Android Team. You can follow the progress there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants