Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify same flavor and image under a different pool name #139

Open
gustaff-weldon opened this issue Jun 28, 2024 · 2 comments
Open
Assignees

Comments

@gustaff-weldon
Copy link

gustaff-weldon commented Jun 28, 2024

What is the feature you would like to have?

We are using logical pool names created not after runner size, but after purpose. Thus we might have two runner pools with the same machine flavor under two names, as we manage underlying machine size independently for each pool.
Atm, operator disallows cration of such pools if flavor, image and repository are the same (even if name differs).

Error: failed to create resource: admission webhook "validate.pool.garm-operator.mercedes-benz.com" 
denied the request: can not create pool, pool=medium with same image=ubuntu-22, flavor=e2-standard-4 
and provider=gcp_external already exists for specified GitHubScope=monorepo

We would like ability to lessen that limitation.

Anything else you would like to add?

No response

@gustaff-weldon gustaff-weldon changed the title Ability to specify same flavor and image under a different name Ability to specify same flavor and image under a different pool name Jun 28, 2024
@gustaff-weldon
Copy link
Author

Also, the admission webhook seems to not work properly (race condition) as I was able to create two pools with the same flavor:

Screenshot 2024-06-28 at 14 47 27

@bavarianbidi
Copy link
Member

Hey @gustaff-weldon thanks for raising this issue and for using the operator 🙏

The reason for that limitation is a garm limitation which exists till v0.1.4.
Gabriel removed that limitation in cloudbase/garm#246

I'm not sure yet, if we should extend the operator in that way, that versions <= v0.1.4 are supported or explicitly pin operator versions to certain garm versions.

@bavarianbidi bavarianbidi self-assigned this Jul 11, 2024
@bavarianbidi bavarianbidi added this to the support for garm > 0.1.4 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants