Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foldseek driver + Structure base Pangenome #2364
base: master
Are you sure you want to change the base?
Foldseek driver + Structure base Pangenome #2364
Changes from 61 commits
ae84460
331ee05
8f239e7
e22b7ef
cc08224
c77da2f
14ca89a
c6b1870
09ec37b
53a28c5
d831632
bca8002
68ed3c2
6794a7e
4d8b09a
7702f9e
747c798
1aecf3a
c37be1f
c2bb89d
0530515
a8a0baa
1e49e96
0267422
97193c6
7e7c1b3
0e63240
b5472ee
5b469d6
b505058
267c4e0
a11babe
e444c62
3ce2d00
8f6640a
dc3f008
04c54cf
f3b7199
07693bd
bbc181d
67d3a39
2079578
27d1b03
a1c53bf
53eab53
4675073
0c56412
2aea34c
a4b36e4
cf3593c
39d6fa4
8e37a55
bf45ce9
df6a2f9
2e2321b
51cbab1
8a09f0c
d900a06
a52e504
19144a2
fde01bf
c0f5a57
d7f09b6
7fe73b5
8056929
bfd5d1e
652592d
0d56d7f
3bdc7b5
8271b6d
9bcbf28
fa75a8b
dd81660
8e38827
52e7579
bb2dd60
5b2ab9b
56b6ff0
007c04d
81664e8
5fa6d4f
3f8449a
3f6c30c
1224a21
fbe6ebe
5eedc71
a735594
1f771ef
f01cd63
e882ae4
c513b1b
82ed1b0
26d2f13
e71fb92
36d1390
d751bcc
2faf2a2
1aa9bd4
e1a48f9
e9f71b2
a659637
2af4f83
2b44fa8
3f63af2
cef9c65
07dc9f6
44e76c7
4cf944f
cbb78b8
7a1c30a
4090e66
9294ca6
6040059
efa8a22
db35551
93443bc
73d7f7c
ab303aa
034ff04
18b1874
b8d5df5
e1d93c2
3519e4c
7538405
d5210a8
8e8421e
6b8e077
7bcf530
449509e
f0d9a74
bb04d6d
f5a3440
e1c7321
e1b24f0
a09b3bc
bb44bff
5c17330
85ec5cc
0a1fd14
3f0cb64
222465f
6766d90
de657c6
2f20e1c
3084b8f
45e9915
c54c086
104b89d
9a0ac37
f1fcd64
da1bb03
7110763
e52cc64
593f85e
ce306b9
983a85f
4f6a850
0355958
12abcd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it
prostt5-data-dir
?Indentations of new entries in
__init__
do not much each other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't forget to change the help files with the new parameter name too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly it seems more correct to use prostt5-weight-dir here. Because what we downloaded is a model's weight file and Foldseek uses it with the same name, for example:
foldseek createdb db.fasta db --prostt5-model weights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter though. As far as our users are concerned, it is yet another data they are downloading. Regardless what individual data items mean to individual processes, we can have a common vocabulary we bring in from the outside world. What we download from COGs is FASTA files. What we download from KEGG is models. We call all of them data on anvi'o side.