From 6e56c46260ad780140995ccb819abd53352a8d53 Mon Sep 17 00:00:00 2001
From: Arthur Gassner <arthur.gassner@gmail.com>
Date: Thu, 5 Dec 2019 19:22:46 +0000
Subject: [PATCH] Revert "Upgrade to Terraform 0.12"

This reverts commit c3e62fff9eda39e8c696247f896e700fcdfb2611.
---
 iam.tf       | 15 +++++----------
 main.tf      | 44 ++++++++++++++++++++------------------------
 outputs.tf   |  8 ++++----
 variables.tf | 11 +++++------
 4 files changed, 34 insertions(+), 44 deletions(-)

diff --git a/iam.tf b/iam.tf
index 404547f..a480884 100644
--- a/iam.tf
+++ b/iam.tf
@@ -1,9 +1,5 @@
 resource "aws_iam_role" "iam_for_lambda" {
-  name_prefix = replace(
-    replace(var.function_name, "/(.{0,32}).*/", "$1"),
-    "/^-+|-+$/",
-    "",
-  )
+  name_prefix        = "${replace(replace(var.function_name, "/(.{0,32}).*/", "$1"), "/^-+|-+$/", "")}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -18,19 +14,18 @@ resource "aws_iam_role" "iam_for_lambda" {
   ]
 }
 EOF
-
 }
 
 resource "aws_iam_role_policy" "lambda_policy" {
-  role = aws_iam_role.iam_for_lambda.id
+  role = "${aws_iam_role.iam_for_lambda.id}"
   name = "policy"
 
-  policy = var.lambda_role_policy
+  policy = "${var.lambda_role_policy}"
 }
 
 resource "aws_iam_role_policy_attachment" "vpc_permissions" {
-  role       = aws_iam_role.iam_for_lambda.name
+  role       = "${aws_iam_role.iam_for_lambda.name}"
   policy_arn = "arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
 
-  count = length(var.subnet_ids) != 0 ? 1 : 0
+  count = "${length(var.subnet_ids) != 0 ? 1 : 0}"
 }
diff --git a/main.tf b/main.tf
index 912070a..53d4a46 100644
--- a/main.tf
+++ b/main.tf
@@ -1,40 +1,36 @@
-terraform {
-  required_version = ">= 0.12"
-}
-
 resource "aws_lambda_function" "lambda_function" {
-  s3_bucket                      = var.s3_bucket
-  s3_key                         = var.s3_key
-  function_name                  = var.function_name
-  role                           = aws_iam_role.iam_for_lambda.arn
-  handler                        = var.handler
-  runtime                        = var.runtime
-  timeout                        = var.timeout
-  memory_size                    = var.memory_size
-  reserved_concurrent_executions = var.reserved_concurrent_executions
-  tags                           = var.tags
+  s3_bucket                       = "${var.s3_bucket}"
+  s3_key                          = "${var.s3_key}"
+  function_name                   = "${var.function_name}"
+  role                            = "${aws_iam_role.iam_for_lambda.arn}"
+  handler                         = "${var.handler}"
+  runtime                         = "${var.runtime}"
+  timeout                         = "${var.timeout}"
+  memory_size                     = "${var.memory_size}"
+  reserved_concurrent_executions  = "${var.reserved_concurrent_executions}"
+  tags                            = "${var.tags}"
 
   vpc_config {
-    subnet_ids         = var.subnet_ids
-    security_group_ids = var.security_group_ids
-  }
+      subnet_ids         = ["${var.subnet_ids}"]
+      security_group_ids = ["${var.security_group_ids}"]
+    }
 
   environment {
-    variables = var.lambda_env
+    variables = "${var.lambda_env}"
   }
 }
 
 resource "aws_cloudwatch_log_group" "lambda_loggroup" {
   name              = "/aws/lambda/${var.function_name}"
   retention_in_days = 7
-  depends_on        = [aws_lambda_function.lambda_function]
+  depends_on      = ["aws_lambda_function.lambda_function"]
 }
 
 resource "aws_cloudwatch_log_subscription_filter" "kinesis_log_stream" {
-  count           = var.datadog_log_subscription_arn != "" ? 1 : 0
+  count           = "${var.datadog_log_subscription_arn != "" ? 1 : 0}"
   name            = "kinesis-log-stream-${var.function_name}"
-  destination_arn = var.datadog_log_subscription_arn
-  log_group_name  = aws_cloudwatch_log_group.lambda_loggroup.name
-  filter_pattern  = var.log_subscription_filter
-  depends_on      = [aws_lambda_function.lambda_function]
+  destination_arn = "${var.datadog_log_subscription_arn}"
+  log_group_name  = "${aws_cloudwatch_log_group.lambda_loggroup.name}"
+  filter_pattern  = "${var.log_subscription_filter}"
+  depends_on      = ["aws_lambda_function.lambda_function"]
 }
diff --git a/outputs.tf b/outputs.tf
index 278805d..61351b8 100644
--- a/outputs.tf
+++ b/outputs.tf
@@ -1,15 +1,15 @@
 output "lambda_arn" {
-  value = aws_lambda_function.lambda_function.arn
+  value = "${aws_lambda_function.lambda_function.arn}"
 }
 
 output "lambda_function_name" {
-  value = aws_lambda_function.lambda_function.function_name
+  value = "${aws_lambda_function.lambda_function.function_name}"
 }
 
 output "lambda_iam_role_name" {
-  value = aws_iam_role.iam_for_lambda.name
+  value = "${aws_iam_role.iam_for_lambda.name}"
 }
 
 output "lambda_invoke_arn" {
-  value = aws_lambda_function.lambda_function.invoke_arn
+  value = "${aws_lambda_function.lambda_function.invoke_arn}"
 }
diff --git a/variables.tf b/variables.tf
index 95b8a9c..d575d12 100644
--- a/variables.tf
+++ b/variables.tf
@@ -19,13 +19,13 @@ variable "runtime" {
 }
 
 variable "subnet_ids" {
-  type        = list(string)
+  type        = "list"
   description = "The VPC subnets in which the Lambda runs."
   default     = []
 }
 
 variable "security_group_ids" {
-  type        = list(string)
+  type        = "list"
   description = "The VPC security groups assigned to the Lambda."
   default     = []
 }
@@ -38,7 +38,7 @@ variable "datadog_log_subscription_arn" {
 
 variable "lambda_role_policy" {
   description = "The Lambda IAM Role Policy."
-  default     = <<END
+  default = <<END
 {
   "Statement": [
     {
@@ -53,7 +53,6 @@ variable "lambda_role_policy" {
   ]
 }
 END
-
 }
 
 variable "timeout" {
@@ -68,7 +67,7 @@ variable "memory_size" {
 
 variable "lambda_env" {
   description = "Environment parameters passed to the Lambda function."
-  type        = map(string)
+  type        = "map"
   default     = {}
 }
 
@@ -84,6 +83,6 @@ variable "reserved_concurrent_executions" {
 
 variable "tags" {
   description = "A mapping of tags to assign to this lambda function."
-  type        = map(string)
+  type        = "map"
   default     = {}
 }