fix(dashboard): type errors

merico-dev · Dec 2, 2024 · d8df70a · d8df70a
1 parent 142d48a
commit d8df70a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/dashboard/src/dashboard-editor/model/datasources/mm-info/metric-detail.utils.ts b/dashboard/src/dashboard-editor/model/datasources/mm-info/metric-detail.utils.ts
@@ -1,20 +1,20 @@
 import _ from 'lodash';
 import {
   CombinedMetricCol,
+  DerivedMetric,
   DimensionColDataType,
   DimensionInfo,
   MetricDetail,
   MetricSourceCol,
 } from './metric-detail.types';
 
-const isDerivedMetric = (data: MetricDetail) => 'cols' in data;
-
 export function parseData(data: MetricDetail) {
-  if (isDerivedMetric(data)) {
+  if ('cols' in data) {
+    const { cols } = data as DerivedMetric;
     return {
-      filters: data.cols.filter((c) => c.type === 'filter').map((c) => c.metricSourceCol),
-      groupBys: data.cols.filter((c) => c.type === 'group_by').map((c) => c.metricSourceCol),
-      trendingDateCol: data.cols.find((c) => c.type === 'trending_date_col')?.metricSourceCol ?? null,
+      filters: cols.filter((c) => c.type === 'filter').map((c) => c.metricSourceCol),
+      groupBys: cols.filter((c) => c.type === 'group_by').map((c) => c.metricSourceCol),
+      trendingDateCol: cols.find((c) => c.type === 'trending_date_col')?.metricSourceCol ?? null,
     };
   }