-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Suspense and Error boundries work with klyva? Also does it work with concurrent mode? They quite stressed this when introducing recoil #30
Comments
Heya :D Regarding suspense...Well, depends on what you're asking. But for suspense, I've explicitly decided to not implement any support for that. I think if you should fetch data, use I honestly don't think suspense brings that much joy to the dev experience anyways? Have you tried it? It made me feel way less secure about my code. Regarding error boundaries:Hmm, how do you mean? Regarding CM...I honestly don't know? Is there any information about this? (I mean, will your code-bases custom hook work with CM?) Yes I have CM anxiety and I'm not even sure the code I write today will be usable when CM rolls out, and we haven't gotten that much info regarding this from the react team. Mostly some talks and no definite tools or experience around CM that makes easy to assert a good answer to your question. I've put klyva in this table here: https://github.com/dai-shi/will-this-react-global-state-work-in-concurrent-mode#results and it looks like there are very few state management solutions that pass the "No-tearing" test. Note that recoil does not pass the test. |
klyva was added in dai-shi/will-this-react-global-state-work-in-concurrent-rendering#28 |
I think I found the one removing klyva, here: dai-shi/will-this-react-global-state-work-in-concurrent-rendering@46187ce |
I should make a PR when I get off work :P |
Perfect. Yes - it looks like an oversight in the reorg :) |
☝️ asking for a friend :) cc @kkogovsek
The text was updated successfully, but these errors were encountered: