From e6783c5d768ee7ea3d130d9708caebc06ff61aa1 Mon Sep 17 00:00:00 2001 From: Pierre B <52003151+pbourdet@users.noreply.github.com> Date: Mon, 1 Jul 2024 16:22:02 +0200 Subject: [PATCH 1/3] Fix warning: add observer as runtime dependency --- merit.gemspec | 1 + 1 file changed, 1 insertion(+) diff --git a/merit.gemspec b/merit.gemspec index 4ff4e57..3ea78ca 100644 --- a/merit.gemspec +++ b/merit.gemspec @@ -14,6 +14,7 @@ Gem::Specification.new do |s| s.add_runtime_dependency 'ambry', '~> 1.0.0' s.add_runtime_dependency 'zeitwerk' + s.add_runtime_dependency 'observer' s.add_development_dependency 'rails', '>= 5.1.6' s.add_development_dependency 'capybara' From cf68c31c4a84407036ce1e3dd5d89efc29dbc11a Mon Sep 17 00:00:00 2001 From: Pierre B <52003151+pbourdet@users.noreply.github.com> Date: Mon, 8 Jul 2024 10:06:02 +0200 Subject: [PATCH 2/3] Added ruby 3.4 in GHA build matrix --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b2b8f0c..504c2a5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby: ['3.1', '3.2', '3.3'] + ruby: ['3.1', '3.2', '3.3', '3.4'] gemfile: - rails_6_1 - rails_7 From c75348b2daa8c862131356a4093d63cabbc41d2e Mon Sep 17 00:00:00 2001 From: Pierre B <52003151+pbourdet@users.noreply.github.com> Date: Mon, 22 Jul 2024 09:50:42 +0200 Subject: [PATCH 3/3] Update Gemfile for ruby 3.4 --- Gemfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index f78ed55..8690034 100644 --- a/Gemfile +++ b/Gemfile @@ -3,9 +3,9 @@ source 'https://rubygems.org' gemspec # Ruby 3.4? -# gem 'base64' -# gem 'mutex_m' -# gem 'observer' +gem 'base64' +gem 'mutex_m' +gem 'observer' gem "rails"