Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d3-shape, d3-path, d3-array are bundled multiple times #4872

Open
tommoor opened this issue Sep 25, 2023 · 5 comments · May be fixed by #4880
Open

d3-shape, d3-path, d3-array are bundled multiple times #4872

tommoor opened this issue Sep 25, 2023 · 5 comments · May be fixed by #4880
Assignees
@Yokozuna59
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@tommoor
Copy link
Contributor

tommoor commented Sep 25, 2023 •
edited
Loading

Description

d3-shape, d3-path, d3-array are bundled multiple times causing the size of the library to be ~50Kb larger than it needs to be (larger than most libraries are to begin with).

Steps to reproduce

Look in pnpm-lock

Screenshots

image

Setup

  • Mermaid version: 10.4.0
@tommoor tommoor added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Sep 25, 2023
@tommoor tommoor mentioned this issue Sep 25, 2023
Closed
@Yokozuna59
Copy link
Member

Hi @tommoor, thanks for reporting, we're already aware of the issue and waiting for d3/d3-sankey#117 to be merged, see d3/d3-sankey#117 (comment).

@tommoor
Copy link
Contributor Author

tommoor commented Sep 25, 2023

Feel free to close as duplicate, but it seems like the maintainer of d3-sankey isn't planning on merging that PR – any thoughts on a way forward? 😢

@Yokozuna59
Copy link
Member

@tommoor I'm not really sure if there's a good solution for such an issue. I wouldn't recommend creating a script to be executed in each install process to remove the old version.

@tommoor
Copy link
Contributor Author

tommoor commented Sep 26, 2023

https://pnpm.io/package_json#pnpmoverrides should be the way to go if the dependencies are otherwise compatible

@Yokozuna59 Yokozuna59 linked a pull request Sep 27, 2023 that will close this issue
Draft
2 tasks
@jgreywolf jgreywolf added include roadmap items to add to roadmap for auto workflow and removed include roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
@Yokozuna59 Yokozuna59 self-assigned this Jan 1, 2024
@tommoor
Copy link
Contributor Author

tommoor commented Nov 16, 2024

This is still the case by the way, these duplicates are adding about 50Kb to the overall package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yokozuna59 Yokozuna59

Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
3 participants
@jgreywolf @tommoor @Yokozuna59