Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ELK to external package #5043

Closed
sidharthv96 opened this issue Nov 18, 2023 · 2 comments · Fixed by #5049 or #5654
Closed

Move ELK to external package #5043

sidharthv96 opened this issue Nov 18, 2023 · 2 comments · Fixed by #5049 or #5654
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@sidharthv96
Copy link
Member

sidharthv96 commented Nov 18, 2023 •
edited
Loading

It appears elkjs is being used from version 9.4.0 and up. However, since elkjs has an Eclipse Public License 2.0 (which is a copyleft license), this forces us (and any commercial closed source users) to use an older version of mermaid-js.

Is there no alternative?

Originally posted by @hermanussen in #1969 (comment)
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Nov 18, 2023
@sidharthv96 sidharthv96 mentioned this issue Nov 20, 2023
Merged
2 tasks
@sidharthv96 sidharthv96 linked a pull request Nov 24, 2023 that will close this issue
Move ELK to standalone package #5049
Merged
2 tasks
@bingenito
Copy link

This dependency has been added back to mermaid core in develop and next. Was that intentional? It will prevent usage by many consumers.

@jonas-jonas jonas-jonas mentioned this issue Apr 25, 2024
Closed
@Gusted Gusted mentioned this issue Jul 19, 2024
Merged
4 tasks
@zszen
Copy link

zszen commented Sep 4, 2024

Me too, I upgrade mermaid-js for Typora mardown. but it never support elk layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move ELK to standalone package mermaid-js/mermaid
Remove elkjs dependency from mermaid package
3 participants
@zszen @sidharthv96 @bingenito