Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users making kernel size too large relative to the window size. #19

Open
Jonolef opened this issue Feb 6, 2017 · 3 comments
Open

Comments

@Jonolef
Copy link
Collaborator

Jonolef commented Feb 6, 2017

Assume there is a mathematical reason, but seemed weird that the RoR graph looked really good, but the temp was so dramatically way off. I had to abandon using the temp readings altogether.

@mesarcik
Copy link
Owner

mesarcik commented Feb 6, 2017

what was the window size? Also 11?

@Jonolef
Copy link
Collaborator Author

Jonolef commented Feb 6, 2017

No. 15.

@mesarcik
Copy link
Owner

mesarcik commented Feb 6, 2017

This might get a bit mathematical.

but in short, i need to prevent users from making the kernel size too big.

Basically the kernel runs through the window and averages out the points, this means if the kernel is 11 and the window is 15 there are only 5 places that the kernel can be in so that it averages the the 11 readings in the window of 15 readings. This means that the average reading you are getting isn't properly representative of the "real average".

I would recomend keeping the kernel at least half the size of the window.

@mesarcik mesarcik changed the title On Moving average filter, set kernel to 11 samples. ROR seemed useful, temp graph was out by about 10degree celsuis. Why? Prevent users making kernel size too large relative to the window size. Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants