Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash calculation of cosmos #1714

Open
NicolasMahe opened this issue Mar 10, 2020 · 0 comments
Open

Use hash calculation of cosmos #1714

NicolasMahe opened this issue Mar 10, 2020 · 0 comments

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Mar 10, 2020

Cosmos-sdk is working on implementing a canonical json representation of their protobuf data to generate signature.
cosmos/cosmos-sdk@9d49fe9
We should wait and reuse the same system to generate deterministic hashes for our resources.

In the meantime, we should revert #1692 to not break anything now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant