Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Consistent Use of MeshKit Errors in Meshery-Istio. #679

Open
2 tasks
singh1203 opened this issue Aug 8, 2024 · 7 comments
Open
2 tasks

Ensure Consistent Use of MeshKit Errors in Meshery-Istio. #679

singh1203 opened this issue Aug 8, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers kind/enhancement Improvement in current feature language/go Golang related

Comments

@singh1203
Copy link
Contributor

singh1203 commented Aug 8, 2024

Current Behavior

Currently, there are instances where errors are being used directly instead of MeshKit errors, which impacts the consistency and quality of error reporting across the project.

Desired Behavior

  • Replace all direct usages of errors with MeshKit errors.
  • Ensure that each MeshKit error includes:- Short Description, Long Description, Probable Cause & Suggested Remediation.

References

Meshery Documentation on Meshkit


Contributor Guides and Resources

@singh1203 singh1203 added the kind/enhancement Improvement in current feature label Aug 8, 2024
Copy link

welcome bot commented Aug 8, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.

@singh1203 singh1203 added good first issue Good for newcomers language/go Golang related labels Aug 8, 2024
@thedeeppp
Copy link

I would like to work on this issue but may need some help

@singh1203
Copy link
Contributor Author

I would like to work on this issue but may need some help

Hey @thedeeppp, don't forget to post your question in the discussion forum or in Slack.

@ShivanshuGupta07
Copy link

@singh1203 , is the above task done or can you please provide some direct helping resources so that I can give it a try?

@singh1203
Copy link
Contributor Author

@ShivanshuGupta07 @thedeeppp Thanks for waiting. Here's the Meshery Docs for running the adapter in your local development environment. Let me know if you need further guidance.

@ShivanshuGupta07
Copy link

@singh1203 ,

  1. can you elaborate on what exactly is required?
  2. where the changes are need to do this task, and how can we verify if the task is completed or not?
  3. Can you elaborate how to replicate current behaviour in my local?
  4. Is there any video for reference?

@ShivanshuGupta07 ShivanshuGupta07 removed their assignment Aug 22, 2024
@ShivanshuGupta07
Copy link

Sorry, by mistake I unassigned myself, @singh1203 can you please reassign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement Improvement in current feature language/go Golang related
Projects
None yet
Development

No branches or pull requests

3 participants