From 82854fce6ce7c4e9102cfff748db70e28fef27ed Mon Sep 17 00:00:00 2001 From: Eti Ijeoma <53005190+Aijeyomah@users.noreply.github.com> Date: Fri, 8 Mar 2024 12:24:59 +0100 Subject: [PATCH 1/2] chore: Set 'display_name' as the default ordering column for models Signed-off-by: Ijeoma Eti Signed-off-by: Eti Ijeoma <53005190+Aijeyomah@users.noreply.github.com> --- models/meshmodel/registry/registry.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/models/meshmodel/registry/registry.go b/models/meshmodel/registry/registry.go index b3ca48a1..911a5aa1 100644 --- a/models/meshmodel/registry/registry.go +++ b/models/meshmodel/registry/registry.go @@ -383,6 +383,8 @@ func (rm *RegistryManager) GetModels(db *database.Handler, f types.Filter) ([]v1 } else { finder = finder.Order(mf.OrderOn) } + } else { + finder = finder.Order("display_name") } finder.Count(&count) From 7483ddccdc9e348afa621a33430da19ce0801be2 Mon Sep 17 00:00:00 2001 From: Eti Ijeoma <53005190+Aijeyomah@users.noreply.github.com> Date: Tue, 12 Mar 2024 18:28:47 +0100 Subject: [PATCH 2/2] fix link to docs for Signing-off on Commits Signed-off-by: Eti Ijeoma <53005190+Aijeyomah@users.noreply.github.com> --- .github/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/config.yml b/.github/config.yml index f67cdc4f..892b9e53 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -8,7 +8,7 @@ newIssueWelcomeComment: > newPRWelcomeComment: > Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the [Layer5 Community Welcome Guide](https://docs.google.com/document/d/17OPtDE_rdnPQxmk2Kauhm3GwXF1R5dZ3Cj8qZLKdo5E/edit?usp=sharing) and sure to join the [community Slack](http://slack.layer5.io/). - Be sure to double-check that you have signed your commits. Here are instructions for [making signing an implicit activity while peforming a commit](../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin). + Be sure to double-check that you have signed your commits. Here are instructions for [making signing an implicit activity while peforming a commit](https://github.com/meshery/meshkit/blob/master/CONTRIBUTING.md#general-contribution-flow). #-------------------------------------------------------------------------------