Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: migrate SettingsFragment to Compose #1432

Open
1 task done
materoy opened this issue Nov 26, 2024 · 4 comments
Open
1 task done

[Enhancement]: migrate SettingsFragment to Compose #1432

materoy opened this issue Nov 26, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@materoy
Copy link

materoy commented Nov 26, 2024

Contact Details

[email protected]

Tell us your idea.

This is a great app with good stability but the UI is really lacking, especially the home screen with the tabs at the to and settings screen could use some bit of user experience improvement.
I have started working on improving them and the PR will be available soon. I just wanted to put it here first so that maintainers would know.

image

This screenshot shows my first improvements but more to com. Please let me know if I'm going in the right direction.

Cheers
~ Matero

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@materoy materoy added the enhancement New feature or request label Nov 26, 2024
@andrekir
Copy link
Member

Thanks for your interest in improving the app! We’re almost done migrating all Fragments to Compose, with only SettingsFragment and parts of ContactsFragment (ActionMenu) and MessagesFragment (ActionMenu and a few components) left.

We'll likely need to finish migrating MessagesFragment and ContactsFragment before we can replace the ViewPager. How do you plan to integrate your changes with the existing Compose navigation?

@materoy
Copy link
Author

materoy commented Nov 26, 2024

Well then if we are taking the bottom up uproach, I can work on the SettingsFragment and migrate it to compose first in the mean time, unless someone else is working on it

@andrekir
Copy link
Member

Sounds good! The "Report Bug" button will be removed, so feel free to take it out during the refactor.

Let me know if you have any questions.

@b8b8
Copy link

b8b8 commented Nov 27, 2024

My thumbs thank you for wanting to move the tabs to the bottom.

@andrekir andrekir changed the title [Enhancement]: Towards improving UI to parity with iOS and perhaps even better [Enhancement]: migrate SettingsFragment to Compose Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants