Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Update wording about Bluetooth not enabled when using HTTP #352

Open
auggie-lahey opened this issue Dec 4, 2024 · 12 comments · May be fixed by #362
Open

[Enhancement]: Update wording about Bluetooth not enabled when using HTTP #352

auggie-lahey opened this issue Dec 4, 2024 · 12 comments · May be fixed by #362
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@auggie-lahey
Copy link

auggie-lahey commented Dec 4, 2024

Bluetooth will only work if the connection is using HTTPS.

The default local setup uses HTTP for its hosting, NOT HTTPS and so Bluetooth connections DO NOT work by default.

Update wording of Connection dialog to notify users.

--

Hardware

Other

Connection Type

Bluetooth

Local or Hosted

http://meshtastic.local

Firmware Version

NA

Description

spin up docker container
go to http://0.0.0.0:8080/
connect new device
bluetooth connection is greyed out and unable to be clicked

Relevant console output

i have connected and confirmed this works in this browser with client.meshtastic.org
@auggie-lahey auggie-lahey added the bug Something isn't working label Dec 4, 2024
@Lebbitheplow
Copy link

Also having this issue, Getting a message "Web Bluetooth and Web Serial are currently only supported by Chromium-based browsers." while on chrome.

@ianmcorvidae
Copy link

The error message possibly does not say it, but it's a browser restriction that web serial and web bluetooth are supported only on https connections.

If you set up SSL and such through a reverse proxy with a certificate, you should be able to use it with a self-hosted copy, though that can be somewhat of a pain depending how you're doing things.

@Lebbitheplow
Copy link

You're definitely right about that one! Configured it under my reverse proxy and it works, Thank you.

@danditomaso
Copy link
Contributor

Just following up on this item, does this mean the current issue can be closed if a new issue was opening requesting the error messages be improved to avoid situations like the one above?

@Hunter275 Hunter275 added the enhancement New feature or request label Dec 30, 2024
@Hunter275 Hunter275 changed the title [Bug]: self-hosted web Bluetooth not enabled [Bug]: self-hosted web Bluetooth not enabled when using HTTP Dec 30, 2024
@Hunter275
Copy link
Member

Just following up on this item, does this mean the current issue can be closed if a new issue was opening requesting the error messages be improved to avoid situations like the one above?

We'll use this issue.

@Hunter275 Hunter275 added help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Dec 30, 2024
@Hunter275 Hunter275 changed the title [Bug]: self-hosted web Bluetooth not enabled when using HTTP [Enhancement]: Update wording about self-hosted web Bluetooth not enabled when using HTTP Dec 30, 2024
@Hunter275
Copy link
Member

@ianmcorvidae Can you confirm the new reading of the issue please?

@Hunter275
Copy link
Member

@danditomaso Are you interested in doing this enhancement?

@danditomaso
Copy link
Contributor

danditomaso commented Dec 30, 2024

Definitely, I should be able to tackle it either tomorrow or Thursday

@ianmcorvidae
Copy link

If you mean the updated title, sounds about right. The restriction doesn't just apply to self-hosted instances, I suppose, but I think the hosted one is already https only so it really only comes up with self-hosting

@Hunter275 Hunter275 changed the title [Enhancement]: Update wording about self-hosted web Bluetooth not enabled when using HTTP [Enhancement]: Update wording about Bluetooth not enabled when using HTTP Dec 31, 2024
@Hunter275
Copy link
Member

If you mean the updated title, sounds about right. The restriction doesn't just apply to self-hosted instances, I suppose, but I think the hosted one is already https only so it really only comes up with self-hosting

Good catch, I've updated the title and such.

@danditomaso
Copy link
Contributor

danditomaso commented Jan 6, 2025

The PR #362 for this issue is ready to go

@danditomaso
Copy link
Contributor

@Hunter275 Wanted to see if you'd have a chance to review this PR this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants