Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure in rust / Windows #13236

Closed
eli-schwartz opened this issue May 19, 2024 · 3 comments
Closed

CI failure in rust / Windows #13236

eli-schwartz opened this issue May 19, 2024 · 3 comments
Labels
language:rust OS:windows Winodows OS specific issues

Comments

@eli-schwartz
Copy link
Member 

================================= rust: 21 transitive dependencies =================================

[...]

Rust compiler for the build machine: rustc -C linker=link (rustc 1.78.0)

[...]

[17/23] "link"  /MACHINE:x64 /OUT:diamond/main.dll diamond/main.dll.p/main.c.obj "/release" "/nologo" "/DEBUG" "/PDB:diamond\main.pdb" "/DLL" "/IMPLIB:diamond\main.lib" "/WHOLEARCHIVE:diamond/libr3.a" "diamond/libr3.a" "diamond/libr1.rlib" "diamond/libc1.a" "diamond/libr2.rlib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "msvcrt.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib"
FAILED: diamond/main.dll diamond/main.pdb 
"link"  /MACHINE:x64 /OUT:diamond/main.dll diamond/main.dll.p/main.c.obj "/release" "/nologo" "/DEBUG" "/PDB:diamond\main.pdb" "/DLL" "/IMPLIB:diamond\main.lib" "/WHOLEARCHIVE:diamond/libr3.a" "diamond/libr3.a" "diamond/libr1.rlib" "diamond/libc1.a" "diamond/libr2.rlib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "msvcrt.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib"
libr3.a(api-ms-win-core-synch-l1-2-0.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR already defined in libr3.a(bcryptprimitives.dll)
LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library
diamond\main.dll : fatal error LNK1169: one or more multiply defined symbols found

Possibly caused by a rust update?

Recent job manifesting the issue: https://dev.azure.com/jussi0947/jussi/_build/results?buildId=21182&view=logs&j=5015ea34-1c35-577b-b206-c8bea8465a58&t=00c5cf7c-b41c-5970-0bf5-8751e484378e&l=1920
@eli-schwartz eli-schwartz added OS:windows Winodows OS specific issues language:rust labels May 19, 2024
gnomesysadmins pushed a commit to GNOME/librsvg that referenced this issue May 27, 2024
@fanc999-1
CI: Force Rust 1.77.2 toolchain for Visual Studio
6bb25f0 
Apparently, the latest stable 1.78.0 is causing linker errors when the librsvg
DLL is being linked.  Upstream Meson/Rust issue is outlined in [1].

Expect the Visual Studio CI job to pass, again :|

ugh... :|

[1]: mesonbuild/meson#13236
gnomesysadmins pushed a commit to GNOME/librsvg that referenced this issue May 27, 2024
@fanc999-1
CI: Force Rust 1.77.2 toolchain for Visual Studio
d79514d 
Apparently, the latest stable 1.78.0 is causing linker errors when the librsvg
DLL is being linked.  Upstream Meson/Rust issue is outlined in [1].

Expect the Visual Studio CI job to pass, again :|

ugh... :|

[1]: mesonbuild/meson#13236

Part-of: <https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/981>
@Nautilus-1021 Nautilus-1021 mentioned this issue Jun 2, 2024
Open
eli-schwartz added a commit to eli-schwartz/meson that referenced this issue Jun 4, 2024
@eli-schwartz
CI: Windows: downgrade rust to 1.77
1da230c 
It started failing CI as soon as the default shifted to 1.78. Something
is broken and it prevents running stable CI. Tracking issue opened.

We pin the version because that is the same way we handle CI for linux
-- with the exception that Linux CI can upgrade itself as soon as we
fix issues causing the CI Image Builder to jam itself, whereas
unfortunately Windows will need to be manually unpinned, but such is
life as a Windows supporter.

Bug: mesonbuild#13236
@eli-schwartz eli-schwartz mentioned this issue Jun 4, 2024
Merged
soumyaDghosh pushed a commit to soumyaDghosh/meson that referenced this issue Jun 4, 2024
@eli-schwartz @soumyaDghosh
CI: Windows: downgrade rust to 1.77
b509add 
It started failing CI as soon as the default shifted to 1.78. Something
is broken and it prevents running stable CI. Tracking issue opened.

We pin the version because that is the same way we handle CI for linux
-- with the exception that Linux CI can upgrade itself as soon as we
fix issues causing the CI Image Builder to jam itself, whereas
unfortunately Windows will need to be manually unpinned, but such is
life as a Windows supporter.

Bug: mesonbuild#13236
jwieleRH pushed a commit to jwieleRH/meson that referenced this issue Jun 5, 2024
@eli-schwartz @jwieleRH
CI: Windows: downgrade rust to 1.77
36c0353 
It started failing CI as soon as the default shifted to 1.78. Something
is broken and it prevents running stable CI. Tracking issue opened.

We pin the version because that is the same way we handle CI for linux
-- with the exception that Linux CI can upgrade itself as soon as we
fix issues causing the CI Image Builder to jam itself, whereas
unfortunately Windows will need to be manually unpinned, but such is
life as a Windows supporter.

Bug: mesonbuild#13236
@fanc999-1
Copy link
Contributor

fanc999-1 commented Jul 16, 2024 •
edited
Loading

Hi,

Some notes here if it did matter, for references:

librsvg recently transitioned from autotools/NMake Makefiles to Meson between 2.58.x and 2.58.9x/2.59.x, and with the latest stable Rust release (1.79.0), the latest stable librsvg (2.58.2) builds successfully with NMake using the latest Visual Studio 2019, but with the latest GIT checkout of librsvg, which is built with Meson, I got:

[6/12] Linking target rsvg/rsvg-2-2.dll
FAILED: rsvg/rsvg-2-2.dll rsvg/rsvg-2-2.pdb
"link"  /MACHINE:x64 /OUT:rsvg/rsvg-2-2.dll rsvg/rsvg-2-2.dll.p/meson-generated_..__rsvg_dummy.c.obj "/release" "/nologo" "/DEBUG" "/PDB:rsvg\rsvg-2-2.pdb" "/DLL" "/DEF:rsvg\librsvg-2.0.def" "/IMPLIB:rsvg\rsvg-2.lib" "/WHOLEARCHIVE:rsvg/rsvg_2.lib" "rsvg/rsvg_2.lib" "c:/vs14.0/x64/lib/cairo.lib" "libpng16.lib" "c:/vs14.0/x64/lib/zlib1.lib" "c:/vs14.0/x64/lib/freetype.lib" "c:/vs14.0/x64/lib/pixman-1.lib" "/LIBPATH:c:/vs14.0/x64/lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "c:/vs14.0/x64/lib/cairo-gobject.lib" "c:/vs14.0/x64/lib/gobject-2.0.lib" "c:/vs14.0/x64/lib/intl.lib" "c:/vs14.0/x64/lib/ffi.lib" "c:/vs14.0/x64/lib/glib-2.0.lib" "c:/vs14.0/x64/lib/pcre2-8.lib" "/LIBPATH:c:/vs14.0/x64/lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "ws2_32.lib" "winmm.lib" "/LIBPATH:c:/vs14.0/x64/lib" "gdi32.lib" "msimg32.lib" "dwrite.lib" "d2d1.lib" "windowscodecs.lib" "c:/vs14.0/x64/lib/dav1d.lib" "c:/vs14.0/x64/lib/gdk_pixbuf-2.0.lib" "c:/vs14.0/x64/lib/jpeg.lib" "c:/vs14.0/x64/lib/tiff.lib" "c:/vs14.0/x64/lib/gio-2.0.lib" "c:/vs14.0/x64/lib/gmodule-2.0.lib" "/LIBPATH:c:/vs14.0/x64/lib" "shlwapi.lib" "dnsapi.lib" "iphlpapi.lib" "ws2_32.lib" "winmm.lib" "/LIBPATH:c:/vs14.0/x64/lib" "shlwapi.lib" "dnsapi.lib" "iphlpapi.lib" "ws2_32.lib" "winmm.lib" "/LIBPATH:c:/vs14.0/x64/lib" "ws2_32.lib" "winmm.lib" "c:/vs14.0/x64/lib/harfbuzz.lib" "/LIBPATH:c:/vs14.0/x64/lib" "usp10.lib" "gdi32.lib" "rpcrt4.lib" "ws2_32.lib" "winmm.lib" "c:/vs14.0/x64/lib/pangocairo-1.0.lib" "c:/vs14.0/x64/lib/pangowin32-1.0.lib" "c:/vs14.0/x64/lib/harfbuzz-gobject.lib" "c:/vs14.0/x64/lib/pango-1.0.lib" "c:/vs14.0/x64/lib/fribidi.lib" "/LIBPATH:c:/vs14.0/x64/lib" "gdi32.lib" "dwrite.lib" "shlwapi.lib" "dnsapi.lib" "iphlpapi.lib" "ws2_32.lib" "usp10.lib" "rpcrt4.lib" "winmm.lib" "msimg32.lib" "d2d1.lib" "windowscodecs.lib" "/LIBPATH:c:/vs14.0/x64/lib" "ws2_32.lib" "winmm.lib" "C:/vs14.0/x64/lib/libxml2.lib" "C:/vs14.0/x64/lib/freetype.lib" "userenv.lib" "ntdll.lib" "ws2_32.lib" "advapi32.lib" "/defaultlib:msvcrt.lib" "kernel32.lib" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
rsvg_2.lib(api-ms-win-core-synch-l1-2-0.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR already defined in rsvg_2.lib(bcryptprimitives.dll)
   Creating library rsvg\rsvg-2.lib and object rsvg\rsvg-2.exp
rsvg\rsvg-2-2.dll : fatal error LNK1169: one or more multiply defined symbols found
ninja: build stopped: subcommand failed.

Please let me know if further info is needed.

With blessings, and cheers!

@kleisauke kleisauke mentioned this issue Aug 10, 2024
Closed
@amyspark amyspark mentioned this issue Aug 12, 2024
Closed
@kleisauke
Copy link
Contributor

Upstream Rust issue: rust-lang/rust#129020.

@eli-schwartz
Copy link
Member Author

eli-schwartz commented Dec 20, 2024 •
edited
Loading

Fixed in upstream rust, the CI pinning has been undone in #14025 / 21614ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language:rust OS:windows Winodows OS specific issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eli-schwartz @kleisauke @fanc999-1