meson cannot handle full paths in ar (windows)

[Neumann-A]

after fixing #9727 locally.

meson/mesonbuild/compilers/detect.py

Line 295 in a2934ca

if not {'lib', 'lib.exe', 'llvm-lib', 'llvm-lib.exe', 'xilib', 'xilib.exe'}.isdisjoint(linker):

will not work if linker is a full path.
meson-native-x64-windows-llvm.log

and thus runs into:

meson/mesonbuild/compilers/detect.py

Lines 331 to 332 in a2934ca

	if p.returncode == 0:
	return ArLinker(linker)

which is wrong. llvm-lib just prints an warning about an unknown option in the detection but that is all (which is why that code path is chosen.).

error:

"C:/Program Files/LLVM/bin/llvm-lib.exe" "csr" libpkgconf.a libpkgconf.a.p/libpkgconf_argvsplit.c.obj libpkgconf.a.p/libpkgconf_audit.c.obj libpkgconf.a.p/libpkgconf_bsdstubs.c.obj libpkgconf.a.p/libpkgconf_cache.c.obj libpkgconf.a.p/libpkgconf_client.c.obj libpkgconf.a.p/libpkgconf_dependency.c.obj libpkgconf.a.p/libpkgconf_fileio.c.obj libpkgconf.a.p/libpkgconf_fragment.c.obj libpkgconf.a.p/libpkgconf_parser.c.obj libpkgconf.a.p/libpkgconf_path.c.obj libpkgconf.a.p/libpkgconf_personality.c.obj libpkgconf.a.p/libpkgconf_pkg.c.obj libpkgconf.a.p/libpkgconf_queue.c.obj libpkgconf.a.p/libpkgconf_tuple.c.obj
csr: no such file or directory

[Neumann-A]

Changed it to if linker[0].endswith(('lib', 'lib.exe', 'llvm-lib', 'llvm-lib.exe', 'xilib', 'xilib.exe')): and now it works....

[Neumann-A]

correct fix is probably if any(os.path.basename(x) in {'lib', 'lib.exe', 'llvm-lib', 'llvm-lib.exe', 'xilib', 'xilib.exe'} for x in linker): stolen from the compiler detection.

[eli-schwartz]

Doesn't seem to be a regression in 0.60.2? Not sure why the title implies it is.

[cannam]

I think we are running into this in an Azure CI build for a library - the CI environment gives the full path of lib.exe for the ar binary entry in a native file, and Meson fails to see that the linker is "Visual Studio like" rather than ar-like.

I can reproduce with Meson 0.61.1 on Windows by creating a file containing just the path to my installation of lib.exe

[binaries]
ar = 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29333/bin/HostX64/x64/lib.exe'

and specifying this using --native-file, whereupon static linking fails with an error like the one mentioned above:

[23/26] "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29333/bin/HostX64/x64/lib.exe" "csr" librubberband_objlib.a librubberband_objlib.a.p/src_rubberband-c.cpp.obj librubberband_objlib.a.p/src_RubberBandStretcher.cpp.obj librubberband_objlib.a.p/src_StretcherProcess.cpp.obj librubberband_objlib.a.p/src_StretchCalculator.cpp.obj librubberband_objlib.a.p/src_base_Profiler.cpp.obj librubberband_objlib.a.p/src_dsp_AudioCurveCalculator.cpp.obj librubberband_objlib.a.p/src_audiocurves_CompoundAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_SpectralDifferenceAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_HighFrequencyAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_SilentAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_ConstantAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_PercussiveAudioCurve.cpp.obj librubberband_objlib.a.p/src_dsp_Resampler.cpp.obj librubberband_objlib.a.p/src_dsp_FFT.cpp.obj librubberband_objlib.a.p/src_system_Allocators.cpp.obj librubberband_objlib.a.p/src_system_sysutils.cpp.obj librubberband_objlib.a.p/src_system_Thread.cpp.obj librubberband_objlib.a.p/src_StretcherChannelData.cpp.obj librubberband_objlib.a.p/src_StretcherImpl.cpp.obj librubberband_objlib.a.p/src_dsp_BQResampler.cpp.obj
FAILED: librubberband_objlib.a
"C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.28.29333/bin/HostX64/x64/lib.exe" "csr" librubberband_objlib.a librubberband_objlib.a.p/src_rubberband-c.cpp.obj librubberband_objlib.a.p/src_RubberBandStretcher.cpp.obj librubberband_objlib.a.p/src_StretcherProcess.cpp.obj librubberband_objlib.a.p/src_StretchCalculator.cpp.obj librubberband_objlib.a.p/src_base_Profiler.cpp.obj librubberband_objlib.a.p/src_dsp_AudioCurveCalculator.cpp.obj librubberband_objlib.a.p/src_audiocurves_CompoundAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_SpectralDifferenceAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_HighFrequencyAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_SilentAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_ConstantAudioCurve.cpp.obj librubberband_objlib.a.p/src_audiocurves_PercussiveAudioCurve.cpp.obj librubberband_objlib.a.p/src_dsp_Resampler.cpp.obj librubberband_objlib.a.p/src_dsp_FFT.cpp.obj librubberband_objlib.a.p/src_system_Allocators.cpp.obj librubberband_objlib.a.p/src_system_sysutils.cpp.obj librubberband_objlib.a.p/src_system_Thread.cpp.obj librubberband_objlib.a.p/src_StretcherChannelData.cpp.obj librubberband_objlib.a.p/src_StretcherImpl.cpp.obj librubberband_objlib.a.p/src_dsp_BQResampler.cpp.obj
Microsoft (R) Library Manager Version 14.28.29337.0
Copyright (C) Microsoft Corporation.  All rights reserved.

LINK : fatal error LNK1181: cannot open input file 'csr'

Is there any way to tell Meson explicitly that the ar command is "Visual Studio like"?