Fix linking when cross-compiling and a windows resource is first object #4724
Conversation
It appears that LIB/LINK default to the host architecture if they can't guess it from the first object. With the MSVC toolchain, resource files are (usually) compiled to an arch-neutral .res format. Always explicitly provide a '/MACHINE:' argument to avoid it guessing incorrectly when cross-compiling.
|
While this contains a test, I couldn't actually get it to fail in CI, currently. Notwithstanding #4402 (comment) I think this only fails when cross-compiling. This is also probably missing the correct handling of this scenario when the visual studio librarian is being used along with other language compilers (e.g. D), (if that even makes sense) For those reasons, this should probably be considered WIP. |
|
Since this is marked as superseding #4040, has this been tested to work for that use case? |
|
I could not reproduce the problem (or even get a warning) using the instructions in #4040 (comment). Perhaps @oleavr can help? |
|
Is the fix itself no longer considered to be WIP? |
|
Merge window is approaching, what should we do with this? |
|
Sorry for the slow response. I'm going to propose this for merging as-is. It's not the best possible PR, but I think it does fix an actual problem, and I'm unlikely to find the time to write a better PR currently. Cross-compiling on Windows needs more work, but hopefully at some stage meson will have some CI which covers that scenario, which will exercise the test added here and show that this change addresses #4463. (I did some manual tests with cross-compiling when writing this change to demonstrate the problem and fix it). |
Closes #4463. Supersedes #4040.