icu: icu-io add include directories #1620
Conversation
| ioinc = include_directories('.') | ||
|
|
||
| icuio_dep = declare_dependency( | ||
| include_directories: ioinc, |
There was a problem hiding this comment.
| ioinc = include_directories('.') | |
| icuio_dep = declare_dependency( | |
| include_directories: ioinc, | |
| icuio_dep = declare_dependency( | |
| include_directories: include_directories('.'), |
There was a problem hiding this comment.
That's mostly a preference thing. I'd keep it as is.
There was a problem hiding this comment.
Unless it's used elsewhere, I don't see the point, especially with meson lack of scoping.
There was a problem hiding this comment.
wrapdb/subprojects/packagefiles/icu/source/i18n/meson.build
Lines 38 to 44 in a5cdf0b
I used i18n code as a reference.
Which is better?
There was a problem hiding this comment.
In the i18n case, it makes sense: i18ninc is used more than one time. (Although the inconsistent naming, not i18n_inc, irks me :P)
There was a problem hiding this comment.
Anyway, don't mind me, if @neheb is happy.
There was a problem hiding this comment.
icuio_depinc makes sense IMO
There was a problem hiding this comment.
Sorry I'm late.
I removed the variables and put them on one line.
|
You need to bump the revision in diff --git i/releases.json w/releases.json
index 2fb522a4..480c49a1 100644
--- i/releases.json
+++ w/releases.json
@@ -1229,6 +1229,7 @@
"gencmn"
],
"versions": [
+ "73.2-3",
"73.2-2",
"73.2-1",
"73.1-1", |
Removed 'ioinc' as it is not used more than once
Closes #1619