Push StasD counters as gauges (#6580)

JIRA issues: DCOS-42671
d2iq-archive · Oct 2, 2018 · da9365d · da9365d
1 parent 2e412f6
commit da9365d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/docs/docs/metrics.md b/docs/docs/metrics.md
@@ -71,6 +71,8 @@ The StatsD reporter can be enabled with `--metrics_statsd` command-line
 flag. It sends metrics over UDP to the host and port specified with
 `--metrics_statsd_host` and `--metrics_statsd_port` respectively.
 
+Counters are forwarded as gauges.
+
 ## DataDog reporter
 
 The DataDog reporter can be enabled with `--metrics_datadog`
@@ -84,7 +86,8 @@ the DataDog cloud over HTTP. It is specified using
 and `api`. If `api` is chosen, your DataDog API key can be supplied with
 `--metrics_datadog_api_key`.
 
-Dashes in metric names are replaced with underscores.
+Dashes in metric names are replaced with underscores. Counters are
+forwarded as gauges.
 
 ## Important metrics
 

diff --git a/src/main/scala/mesosphere/marathon/metrics/current/reporters/DataDogAPIReporter.scala b/src/main/scala/mesosphere/marathon/metrics/current/reporters/DataDogAPIReporter.scala
@@ -87,7 +87,7 @@ class DataDogAPIReporter(metricsConf: MetricsConf, registry: MetricRegistry) ext
   }
 
   private def reportCounter(buffer: StringBuilder, name: String, counter: Counter, timestamp: Long): Unit =
-    reportMetric(buffer, name, counter.getCount.toString, timestamp, "count")
+    reportMetric(buffer, name, counter.getCount.toString, timestamp, "gauge")
 
   private val histogramSnapshotSuffixes =
     Seq("min", "average", "median", "75percentile", "95percentile", "98percentile",

diff --git a/src/main/scala/mesosphere/marathon/metrics/current/reporters/DataDogUDPReporter.scala b/src/main/scala/mesosphere/marathon/metrics/current/reporters/DataDogUDPReporter.scala
@@ -81,7 +81,7 @@ class DataDogUDPReporter(metricsConf: MetricsConf, registry: MetricRegistry) ext
   }
 
   private def reportCounter(socket: ActorRef, name: String, counter: Counter): Unit =
-    maybeSendAndAppend(socket, s"$name:${counter.getCount}|c\n")
+    maybeSendAndAppend(socket, s"$name:${counter.getCount}|g\n")
 
   private val histogramSnapshotSuffixes =
     Seq("min", "average", "median", "75percentile", "95percentile", "98percentile",

diff --git a/src/main/scala/mesosphere/marathon/metrics/current/reporters/StatsDReporter.scala b/src/main/scala/mesosphere/marathon/metrics/current/reporters/StatsDReporter.scala
@@ -78,7 +78,7 @@ class StatsDReporter(metricsConf: MetricsConf, registry: MetricRegistry) extends
   }
 
   private def reportCounter(socket: ActorRef, name: String, counter: Counter): Unit =
-    maybeSendAndAppend(socket, s"$name:${counter.getCount}|c\n")
+    maybeSendAndAppend(socket, s"$name:${counter.getCount}|g\n")
 
   private val histogramSnapshotSuffixes =
     Seq("min", "mean", "p50", "p75", "p95", "p98", "p99", "p999", "max", "stddev")