From ea8512b54e7585c51223740c6a870262e673b68e Mon Sep 17 00:00:00 2001 From: Ruud Kamphuis Date: Thu, 31 Oct 2024 10:27:26 +0100 Subject: [PATCH 1/2] Add PHP 8.3 and PHP 8.4 to matrix --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index bb0edc4..3fc0437 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: true matrix: - php: [ '7.4', '8.0', '8.1', '8.2' ] + php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ] stability: [ prefer-stable ] name: PHP ${{ matrix.php }} - ${{ matrix.stability }} From 3a353d8fd0e5f0f646dbc061826afe9be5d88699 Mon Sep 17 00:00:00 2001 From: Ruud Kamphuis Date: Thu, 31 Oct 2024 10:28:02 +0100 Subject: [PATCH 2/2] Make compatible with PHP 8.4 > MessageBird\Client::__construct(): Implicitly marking parameter $httpClient as nullable is deprecated, the explicit nullable type must be used instead --- src/MessageBird/Client.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MessageBird/Client.php b/src/MessageBird/Client.php index ab84987..cc14b6e 100644 --- a/src/MessageBird/Client.php +++ b/src/MessageBird/Client.php @@ -147,7 +147,7 @@ class Client */ protected $numbersAPIClient; - public function __construct(?string $accessKey = null, Common\HttpClient $httpClient = null, array $config = []) + public function __construct(?string $accessKey = null, ?Common\HttpClient $httpClient = null, array $config = []) { if ($httpClient === null) { $this->conversationsAPIHttpClient = new Common\HttpClient(