Skip to content

Commit b72ba03

Browse files
authored
(torchx/schedulers) Retire gcp batch scheduler
Differential Revision: D82797094 Pull Request resolved: #1122
1 parent 1f79761 commit b72ba03

18 files changed

+7
-1091
lines changed

.github/workflows/components-integration-tests.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,6 @@ jobs:
5959
pip install -r dev-requirements.txt
6060
pip install -e .[kubernetes]
6161
62-
- name: Start Ray
63-
if: ${{ matrix.scheduler == 'ray' }}
64-
run: |
65-
ray start --head
66-
sleep 5 # wait till the node joins so that `status` command displays the head node info
67-
ray status
68-
6962
- name: Start Kubernetes
7063
if: ${{ matrix.scheduler == 'kubernetes' }}
7164
run: |

.github/workflows/gcp-batch-integration-tests.yaml

Lines changed: 0 additions & 37 deletions
This file was deleted.

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ TorchX currently supports:
1919
* AWS Batch
2020
* Docker
2121
* Local
22-
* GCP Batch (prototype)
2322

2423
Need a scheduler not listed? [Let us know!](https://github.com/pytorch/torchx/issues?q=is%3Aopen+is%3Aissue+label%3Ascheduler-request)
2524

dev-requirements.txt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ kubernetes==25.3.0
77
flake8==3.9.0
88
fsspec==2024.3.1
99
s3fs==2024.3.1
10-
google-cloud-batch==0.17.14
11-
google-cloud-logging==3.10.0
12-
google-cloud-runtimeconfig==0.34.0
1310
hydra-core
1411
ipython
1512
mlflow-skinny
@@ -34,10 +31,3 @@ wheel
3431
# lint (linter versions are managed by lintrunner)
3532
lintrunner
3633
lintrunner-adapters
37-
38-
39-
# reduce backtracking
40-
grpcio==1.62.1
41-
grpcio-status==1.48.1
42-
googleapis-common-protos==1.63.0
43-
google-api-core==2.18.0

docs/source/index.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ Works With
7777
schedulers/aws_batch
7878
schedulers/aws_sagemaker
7979
schedulers/lsf
80-
schedulers/gcp_batch
8180

8281
.. fbcode::
8382

docs/source/schedulers/gcp_batch.rst

Lines changed: 0 additions & 18 deletions
This file was deleted.

requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,4 @@ pyyaml
33
docker
44
filelock
55
fsspec>=2023.10.0
6-
# To resolve confliciting dependencies for urllib3: https://github.com/pytorch/torchx/actions/runs/3484190429/jobs/5828784263#step:4:552
7-
urllib3<1.27,>=1.21.1
86
tabulate

scripts/component_integration_tests.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def main() -> None:
6565
"local_docker",
6666
"aws_batch",
6767
"lsf",
68-
"gcp_batch",
6968
):
7069
build = build_and_push_image(args.container_repo)
7170
torchx_image = build.torchx_image
@@ -120,23 +119,6 @@ def main() -> None:
120119
"queue": "torchx",
121120
},
122121
},
123-
"gcp_batch": {
124-
"providers": [
125-
component_provider,
126-
],
127-
"image": torchx_image,
128-
"cfg": {},
129-
},
130-
"ray": {
131-
"providers": [
132-
component_provider,
133-
],
134-
"image": torchx_image,
135-
"cfg": {
136-
"requirements": "",
137-
},
138-
"workspace": f"file://{os.getcwd()}",
139-
},
140122
"lsf": {
141123
"providers": [
142124
component_provider,

scripts/gcpbatchint.sh

Lines changed: 0 additions & 30 deletions
This file was deleted.

scripts/slurmdockerint.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ REMOTE_SCRIPT="$DIR/$(basename "$SCRIPT")"
4040

4141
for host in c1 c2
4242
do
43-
docker exec "$host" dnf install python39 -y
43+
docker exec "$host" dnf install python3.11 -y
4444
done
4545

4646
run_cmd mkdir -p "$DIR"
47-
run_cmd python3.9 -m venv "$VENV"
47+
run_cmd python3.11 -m venv "$VENV"
4848
run_scp "$WHEEL" "$REMOTE_WHEEL"
4949
run_scp "$SCRIPT" "$REMOTE_SCRIPT"
5050
run_cmd "$REMOTE_SCRIPT" "$REMOTE_WHEEL" "$VENV"

0 commit comments

Comments
 (0)