Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golangci-lint does not lint release note tools etc #2090

Open
tuminoid opened this issue Nov 29, 2024 · 4 comments
Open

Golangci-lint does not lint release note tools etc #2090

tuminoid opened this issue Nov 29, 2024 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

tuminoid commented Nov 29, 2024 •
edited
Loading

Golangci-lint does not lint release note tools etc. Check the configuration what else is missed.

In .golangci.yaml we whitelist directories golangci-lint looks at, so adding all missing directories with .go files there, for example hack/tools/release and then addressing issues linting reveals in those go files.

/kind bug
@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 29, 2024
@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted
/help

@metal3-io-bot
Copy link
Contributor

@Rozzii:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
@Rozzii Rozzii added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 4, 2024
@payalkanyan
Copy link

Hi @tuminoid and @Rozzii, I would greatly appreciate it if you could share more details regarding the issue. Your insights would be invaluable in helping me address it more effectively.

@tuminoid
Copy link
Member Author

tuminoid commented Dec 5, 2024

Hi @tuminoid and @Rozzii, I would greatly appreciate it if you could share more details regarding the issue. Your insights would be invaluable in helping me address it more effectively.

I've updated the description to be more precise of the actions needed. Thanks for calling out badly defined issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tuminoid @Rozzii @metal3-io-bot @payalkanyan