Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm64 builds for sushy-tools container #615

Open
e-minguez opened this issue Feb 3, 2025 · 2 comments · May be fixed by #616
Open

Enable arm64 builds for sushy-tools container #615

e-minguez opened this issue Feb 3, 2025 · 2 comments · May be fixed by #616
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@e-minguez
Copy link
Contributor

https://quay.io/repository/metal3-io/sushy-tools provides the sushy-tool containerized for easy usage. It would be nice if arm64 builds of that container image can be enabled.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Feb 3, 2025
@e-minguez
Copy link
Contributor Author

After reading https://github.com/metal3-io/ironic-image/blob/main/.github/workflows/build-images-action.yml#L29C11-L29C83 & https://github.com/metal3-io/project-infra/blob/main/.github/workflows/container-image-build.yml#L85C13-L85C52 it seems the builds are done by the https://github.com/mr-smithers-excellent/docker-build-push action which seems to support multi-platform builds per https://github.com/mr-smithers-excellent/docker-build-push?tab=readme-ov-file#multi-platform-builds

  - uses: mr-smithers-excellent/docker-build-push@v6
    name: Build & push Docker image
    with:
      image: repo/image
      registry: docker.io
      multiPlatform: true
      platform: linux/amd64,linux/arm64,linux/arm/v7
      username: ${{ secrets.DOCKER_USERNAME }}
      password: ${{ secrets.DOCKER_PASSWORD }}

Probably I'm missing something and it is not that easy 😅

@Rozzii
Copy link
Member

Rozzii commented Feb 4, 2025

/triage accepted
Lets use this Issue and your PRs as a POC/experiment. We as a community has been long thinking on incorporating ARM support.
Please add documentation to the README in the root that ARM images are only experimental and not tested.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants