Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ansible filters from netcommon to utils #1492

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

elfosardo
Copy link
Member

The netcommon filters will stop working soon, they've been migrated to the utils module.

Closes #1491

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@elfosardo elfosardo force-pushed the ansible-utils-migration branch from 8b0d282 to 6b64be5 Compare January 15, 2025 14:32
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

@elfosardo
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

1 similar comment
@elfosardo
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@tuminoid
Copy link
Member

There are more:

00:23:36.174  [DEPRECATION WARNING]: Use 'ansible.utils.ipmath' module instead. This feature 
00:23:36.174  will be removed from ansible.netcommon in a release after 2024-01-01. 
00:23:58.451  [DEPRECATION WARNING]: Use 'ansible.utils.ipwrap' module instead. This feature 
00:23:58.451  will be removed from ansible.netcommon in a release after 2024-01-01. 

The netcommon filters will stop working soon, they've been migrated
to the utils module.

Signed-off-by: Riccardo Pittau <[email protected]>
@elfosardo elfosardo force-pushed the ansible-utils-migration branch from 6b64be5 to 50909c6 Compare January 17, 2025 08:33
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more deprecation warnings, yay. Thanks!

/approve
/cc @lentzi90

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@metal3-io-bot metal3-io-bot merged commit 323a572 into metal3-io:main Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ansible deprecation warnings
4 participants