Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-guide: migrate BareMetalHost and HardwareData API docs from BMO #314

Open
dtantsur opened this issue Mar 8, 2023 · 14 comments
Open
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

dtantsur commented Mar 8, 2023

We need to have user-facing content in the user guide. I suggest we have a single page for BMH and HardwareData.

Migrate the description from https://github.com/metal3-io/baremetal-operator/blob/main/docs/api.md
Migrate state machine from https://github.com/metal3-io/baremetal-operator/blob/main/docs/baremetalhost-states.md (with images)
Synchronize and delete BMO copies of https://github.com/metal3-io/baremetal-operator/blob/main/docs/inspectAnnotation.md
and https://github.com/metal3-io/baremetal-operator/blob/main/docs/statusAnnotation.md

/kind documentation
/help

@metal3-io-bot
Copy link
Contributor

@dtantsur:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

We need to have user-facing content in the user guide. I suggest we have a single page for BMH and HardwareData.

Migrate from https://github.com/metal3-io/baremetal-operator/blob/main/docs/api.md

/kind documentation
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added kind/documentation Categorizes issue or PR as related to documentation. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Mar 8, 2023
@dtantsur
Copy link
Member Author

dtantsur commented Mar 8, 2023

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Mar 8, 2023
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2023
@dtantsur
Copy link
Member Author

dtantsur commented Jun 7, 2023

/remove-lifecycle stale
/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2023
@SafeEHA
Copy link
Contributor

SafeEHA commented Sep 21, 2024

@Rozzii i'll be happy help with this

@Rozzii
Copy link
Member

Rozzii commented Sep 24, 2024

@SafeEHA thanks!
/assign @SafeEHA

@Rozzii
Copy link
Member

Rozzii commented Sep 24, 2024

/remove-lifecycle frozen

@metal3-io-bot metal3-io-bot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Sep 24, 2024
@SafeEHA
Copy link
Contributor

SafeEHA commented Sep 30, 2024

Hi @Rozzii
I missed this last week, so just to be clear I am to migrate the api.md file and baremetalhost-states.md file to some other directory?

Then also sync (merge) inspectAnnotation.md file and statusAnnotation.md files into just a single file ?

@Rozzii
Copy link
Member

Rozzii commented Oct 1, 2024

Hi @Rozzii I missed this last week, so just to be clear I am to migrate the api.md file and baremetalhost-states.md file to some other directory?

Then also sync (merge) inspectAnnotation.md file and statusAnnotation.md files into just a single file ?

The goal would be to have all the documentation in the metal3-docs user-guide. Yes the you would need to merge the two annotations files to one. IMO everything can be relocated to metal3-doc user-guide but if @dtantsur thinks it is better to leave the status annotation doc here that is fine by me too.

@SafeEHA
Copy link
Contributor

SafeEHA commented Oct 2, 2024

@Rozzii To confirm, i'll be moving the api.md file and baremetalhost-states.md to the "basic features" section of the Baremetal Operator in the user-guide?
Also, can i name the status annotation and inspect annotation files annotation.md after merging both?

@SafeEHA
Copy link
Contributor

SafeEHA commented Oct 3, 2024

Just created this, I see the reviewers of PRs in the BMO repo aren't you guys...can you help take a look @Rozzii and let me know if it's what you had in mind?

@tuminoid
Copy link
Member

tuminoid commented Oct 3, 2024

@Rozzii To confirm, i'll be moving the api.md file and baremetalhost-states.md to the "basic features" section of the Baremetal Operator in the user-guide? Also, can i name the status annotation and inspect annotation files annotation.md after merging both?

I think the descriptions says to move docs from BMO to here, and then sync BMO side docs to reference the new docs here to avoid duplication.

@SafeEHA
Copy link
Contributor

SafeEHA commented Oct 3, 2024

Thanks for pointing this out @dtantsur, i've done just that in Pull #475

@Rozzii
Copy link
Member

Rozzii commented Oct 3, 2024

@Rozzii To confirm, i'll be moving the api.md file and baremetalhost-states.md to the "basic features" section of the Baremetal Operator in the user-guide? Also, can i name the status annotation and inspect annotation files annotation.md after merging both?

I have started to type a response to you but got distracted, sorry.
I am in agreement with @tuminoid so stuff should land here in user-guide and BMO should reference them if needed. I have checked your PR and it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants