Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pivoting.html): fix broken links #531

Merged
merged 1 commit into from
Nov 29, 2024
Merged

docs(pivoting.html): fix broken links #531

merged 1 commit into from
Nov 29, 2024

Conversation

wallchristopher
Copy link
Contributor

Fixes #525

Updated links within the Pivoting blogpost.

For move.md it appears it was deleted and replaced within this PR.

For the other two (move.yml and move_back.yml) it was a move within this PR

Verified they redirect running local instance make serve

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2024
@metal3-io-bot
Copy link
Contributor

Hi @wallchristopher. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 9ddd8a3
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/67488049a1ee310008b3c421
😎 Deploy Preview https://deploy-preview-531--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wallchristopher wallchristopher changed the title docs(pivoting.md): fix broken links docs(pivoting.html): fix broken links Nov 27, 2024
lekaf974
lekaf974 approved these changes Nov 28, 2024
View reviewed changes
Copy link

@lekaf974 lekaf974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2024
tuminoid
tuminoid reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Awesome that you linked the PRs that broke the links, makes reviewing much easier. Looks good otherwise, one comment.

_posts/2021-05-05-Pivoting.md Outdated
@@ -38,7 +38,7 @@ addressed:
- Objects should have a proper owner reference chain.

For a detailed explanation of the above-mentioned prerequisites please read the
[pivoting documentation](https://github.com/metal3-io/metal3-docs/blob/master/docs/move.md).
[pivoting documentation](https://github.com/metal3-io/metal3-docs/blob/main/docs/user-guide/src/capm3/pivoting.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anytime content is pointing to user-guide, then we should link the rendered output at metal3-io. In this case that would be https://book.metal3.io/capm3/pivoting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, updated

@wallchristopher
fix broken links
9ddd8a3 
Signed-off-by: Wall Christopher <[email protected]>
@wallchristopher
Copy link
Contributor Author

Glad to help

tuminoid
tuminoid reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@tuminoid
Copy link
Member

/cc @lentzi90

lentzi90
lentzi90 reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lekaf974, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@metal3-io-bot metal3-io-bot merged commit 8c7856a into metal3-io:source Nov 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@lekaf974 lekaf974 lekaf974 approved these changes

@elfosardo elfosardo Awaiting requested review from elfosardo

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links in https://metal3.io/blog/2021/05/05/Pivoting.html
5 participants
@wallchristopher @metal3-io-bot @tuminoid @lekaf974 @lentzi90