Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow: Switch to staging registry #908

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Prow: Switch to staging registry #908

merged 1 commit into from
Nov 23, 2024

Conversation

lentzi90
Copy link
Member

The GCR is about to be shut down. Prow already stopped publishing images there but have not transitioned to registry.k8s.io yet. Because of this we are switching to use the staging registry instead, which is the same that the k/k prow is also using.

Related to #871 (doesn't fix, since the issue is for migrating to registry.k8s.io)

@lentzi90
Prow: Switch to staging registry
797a3b6 
The GCR is about to be shut down. Prow already stopped publishing images
there but have not transitioned to registry.k8s.io yet. Because of this
we are switching to use the staging registry instead, which is the same
that the k/k prow is also using.

Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
@lentzi90
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main
Changes are applied, except the utility images that will be auto-applied when this merges.

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
Changes are applied, except the utility images that will be auto-applied when this merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@tuminoid tuminoid mentioned this pull request Nov 22, 2024
Open
Sunnatillo
Sunnatillo approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Perfect. Thank you

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 40f883a into metal3-io:main Nov 23, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/prow-use-staging-registry branch November 23, 2024 00:21
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the following 2 configmaps:

  • job-config configmap in namespace prow at cluster default using the following files:
    • key project-infra.yaml using file prow/config/jobs/metal3-io/project-infra.yaml
    • key periodics.yaml using file prow/config/jobs/periodics.yaml
  • config configmap in namespace prow at cluster default using the following files:
    • key config.yaml using file prow/config/config.yaml

In response to this:

The GCR is about to be shut down. Prow already stopped publishing images there but have not transitioned to registry.k8s.io yet. Because of this we are switching to use the staging registry instead, which is the same that the k/k prow is also using.

Related to #871 (doesn't fix, since the issue is for migrating to registry.k8s.io)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lentzi90 @metal3-io-bot @tuminoid @Sunnatillo