Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module schemas need to be added into the schemas_all.yaml file #23

Open
ronaldtse opened this issue May 8, 2024 · 7 comments
Open

Module schemas need to be added into the schemas_all.yaml file #23

ronaldtse opened this issue May 8, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

Right now the collection does not include module documents, so the schemas are not collected inside schemas_all.yaml.

We need to either include all the module documents in the collection, or use a new schemas_all.yaml that includes EVERYTHING.

@ronaldtse ronaldtse added the bug Something isn't working label May 8, 2024
@ronaldtse
Copy link
Contributor Author

The workaround for a module document now is just:

Was:

:lutaml-express-index: schemas; ../../schemas_all.yaml;

Change to:

:lutaml-express-index: schemas; schemas.yaml;

@TRThurman
Copy link

@ronaldtse, clarification request:
isn't schemas all exist in the scope of the srl, which is limited to resources?

Maybe you are doing integration testing using the smrl approach?

@ronaldtse
Copy link
Contributor Author

@TRThurman Do the resource and module schemas reference each other? If they do, and if they are in the same collection, we need to load both types of schemas in the same instance so the links can be generated.

@TRThurman
Copy link

@ronaldtse modules reference resource schemas.
resources just reference other resource documents.
For now keep it as you say.

@ronaldtse
Copy link
Contributor Author

I actually wonder if we should split the resource and module documents into two folders for easier management.

@TRThurman
Copy link

Maybe, depends how much monkeying around you are doing with the collection files.
Probably let it be the way it is since that will work, and modules do need to reference the resource schemas.

@TRThurman
Copy link

suggestion: keep a stable environment until after the ISO SC4 meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants