Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support frame=none,grid=none #101

Open
Intelligent2013 opened this issue Jul 4, 2023 · 1 comment
Open

Support frame=none,grid=none #101

Intelligent2013 opened this issue Jul 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Intelligent2013
Copy link
Contributor

Source issue: #48

The example contains the data in the borderless table. Source PDF fragment:
image

I've tried to add frame=none,grid=none (from https://docs.asciidoctor.org/asciidoc/latest/tables/borders/):

[cols="1,1,1",options="unnumbered",frame=none,grid=none]
|===
| 締結用部品- +
(前置き要素)
| おねじ部品- +
(主要素)
| 呼び長さ及びねじ部長さ +
(補完要素)

|===

but in the Presentation XML there aren't any mentions about borders:

<table id="_722aa30a-13f0-f3ce-c66c-9c39c6c2df96" unnumbered="true">
	<thead/>
	<colgroup>
		<col width="33.3333%"/>
		<col width="33.3333%"/>
		<col width="33.3334%"/>
	</colgroup>
	<tbody>
		<tr>
			<td align="left" valign="top">締結用部品-
                                            <br/>(前置き要素)</td>
			<td align="left" valign="top">おねじ部品-
                                            <br/>(主要素)</td>
			<td align="left" valign="top">呼び長さ及びねじ部長さ
                                            <br/>(補完要素)</td>
		</tr>
	</tbody>
</table>

Is there a way to turn-off the table borders?

@Intelligent2013 Intelligent2013 added the enhancement New feature or request label Jul 4, 2023
@opoudjis
Copy link
Contributor

Is there a way to turn-off the table borders?

Not yet: the frame and grid parameters are simply ignored in processing Asciidoctor. And I am going to resist suggestions of ad hoc formatting of tables, unless they are explicitly required by the SDO. All SDOs we have dealt with are strict with table formatting: they either require one style for all of them, or else they semantically motivate the different ways of rendering them. I do not welcome turning off table borders, and I would want a genuine reason for doing so.

"We did that in that one document (where it wasn't even a table but an example)" is not enough of a genuine reason.

Yes. I know I am being Dr No about feature modifications in Metanorma. But someone has to be. The more freedom we give to formatting, the more Metanorma degenerates into just being Word.

I am unwilling to do this until we have had a real discussion with JIS, or unless you can provide me with a principled motivation (e.g. tables within examples are always borderless).

@opoudjis opoudjis self-assigned this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏕 Med priority
Development

No branches or pull requests

2 participants