Issues updating existing NFTs

[aaronlinsky]

Hi @lorisleiva (I'm alph42 from discord). Thanks for both making this package and offering to help!

Context

I mint NFTs currently using the old metaplex/js package. I then manually add them to a collection using the mpl-token-metadata package. OpenSea has picked up the collection and displays it, which is great, but I have a few "test" NFTs in my collection (see if you can spot them) and I'd like them not to display, and I want to clean up the collection anyways. Even after resetting verified=0 using metaboss, the NFTs were still showing up (which is an issue with OpenSea's implementation I believe) so I decided to try out js-next since it seems like I should be able to easily update any metadata including removing the collection struct entirely.

Isses

1. When attempting to retrieve a "burnt" NFT via findNftByMint, I get an odd error message likely due to the fact that the URI="" and the function fails. I would like to still be able to update a burnt NFT if I have updateAuthority on it.
2. When I tried to test a rename using updateNft, that function provides a different fairly opaque (at least for me) error.

Code

  const connection = new web3.Connection(web3.clusterApiUrl("mainnet-beta"));

  const keypair = await web3.Keypair.fromSecretKey(
    base58.decode("UpdateAuthorityKey")
  );

  const metaplex = Metaplex.make(connection)
    .use(keypairIdentity(keypair))
    .use(bundlrStorage());


  const mint = new web3.PublicKey("7wh23HUPrpYMMKgrQm38ZnpzER2AkDuABcTakeu2gTVv"); // Mint exists
  // const mint = new web3.PublicKey("BCeZe5hpwNBTq5euBi6WWvAWtuF2cpukfQUTcNa8wCPn"); // "burnt" nft but still has the collection in the metadata


  const nft = await metaplex.nfts().findNftByMint(mint)

  console.log(nft)

  const { nft: updatedNft } = await metaplex.nfts().updateNft(nft, {
    name: "Test Update",
  });


  console.log(updatedNft);

Error message (for 2)

TypeError: this.metaplex.connection.getLatestBlockhash is not a function
    at Web3RpcDriver.<anonymous> (/Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:84:52)
    at Generator.next (<anonymous>)
    at /Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:4:12)
    at Web3RpcDriver.getLatestBlockhash (/Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:83:16)
    at Web3RpcDriver.<anonymous> (/Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:27:123)
    at Generator.next (<anonymous>)
    at /Users/aaron/dev/first-ink/node_modules/@metaplex-foundation/js-next/dist/cjs/drivers/rpc/Web3RpcDriver.js:8:71
    at new Promise (<anonymous>)

[lorisleiva]

Hey Aaron 👋

Thanks for the detailed explanation, I think it makes a lot of sense. Also, searching through the test NFTs in your collection on NFT made me laugh. 😅

Regarding your points:

1. Yes, this is the current expected behaviour but I can see why it would be annoying not to be able to retrieve an NFT because its URI is invalid. I will create a separate issue for this and fix it. To be precise, running the metadataTask explicitly will still throw an error for invalid URIs but I'll make sure to catch this error when running findNftByMint so it doesn't block users from accessing them.

2. That's because getLatestBlockhash used to be called getRecentBlockhash and is now deprecated. My guess is that your web3.js version is a bit behind. I'll try to fix this by updating the web3.js dependency version in the SDK's package.json.
   EDIT: This method is actually already available from ^1.37.0 which is the current dependency version used by the SDK. You might be forcing an older version in your package.json. Let me know if that's the case. 🙂

Thanks again for these findings, that's super helpful! 🍺

[aaronlinsky]

That was quick!

All I tried to do was update the name of the NFT (using the code sample above). That said, my goal is to change the collection address (or set it to an empty string), I just was starting with the documented usage to get something simple working.

[lorisleiva]

Got it! So this is an issue with the SDK because we haven't yet tackled collections as a feature and therefore we've not tested all the edge cases. But that's on our list of things to do right now so it should all be available soon. 🙂

In the meantime, in your case, I'm pretty sure explicitly providing null as a collection will actually fix your issue.

If you just wanted to update the name right now whilst keeping the collection, I think a temporary hack would be to pass { key: yourCollectionPublicKey, verified: false } to the collection parameter to ensure it is not overridden by { key: yourCollectionPublicKey, verified: true } which causes the program error.

Let me know if that work for you for the moment.

[aaronlinsky]

Thanks, and that makes sense. Looking forward to the collection functionality and whenever this package is recommended for Prod use.

I ended up just using the cli-nft tool to change the collection to another nft with the same update authority. Unfortunately, OpenSea doesn't appear to handle collection updates, so my NFTs are still showing up as part of the collection even though they now point to a different collection AND are not approved :-/

Thanks again for your help here!

[lorisleiva]

Have you tried refreshing the metadata on the NFT you've updated on OpenSea? You can't do that for a whole collection but if you click on the NFT you should have a "Refresh Metadata" on the top right corner.

[aaronlinsky]

Yea, been smashing that refresh button for a few days now my guess is that it isn't looking at the collection. I haven't tried changing other metadata to see if that flows through.

What's interesting is even my "burned" NFT is still showing up in OS. At least you can't bid on it...

Burned NFT: https://explorer.solana.com/address/BCeZe5hpwNBTq5euBi6WWvAWtuF2cpukfQUTcNa8wCPn
OpenSea: https://opensea.io/assets/solana/BCeZe5hpwNBTq5euBi6WWvAWtuF2cpukfQUTcNa8wCPn