Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZBL follow-up #355

Open
frostedoyster opened this issue Oct 9, 2024 · 0 comments
Open

ZBL follow-up #355

frostedoyster opened this issue Oct 9, 2024 · 0 comments
Assignees
@frostedoyster
Labels
Infrastructure: Miscellaneous General infrastructure issues Priority: Medium Important issues to address after high priority.

Comments

@frostedoyster
Copy link
Collaborator

#335 leaves a few problems open for ZBL:

  • units
  • should the composition model be fit before or after removing ZBL? At the moment, it's "before" for the native models and "after" for PET
  • the current version breaks distributed training by working on CPU (DistributedDataParallel doesn't like it)
@frostedoyster frostedoyster added Priority: Medium Important issues to address after high priority. Infrastructure: Miscellaneous General infrastructure issues labels Oct 9, 2024
@frostedoyster frostedoyster self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frostedoyster frostedoyster

Labels
Infrastructure: Miscellaneous General infrastructure issues Priority: Medium Important issues to address after high priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frostedoyster