Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging/tracing #581

Open
Yohe-Am opened this issue Feb 7, 2024 · 1 comment
Open

Improve logging/tracing #581

Yohe-Am opened this issue Feb 7, 2024 · 1 comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code meta-cli pr:rust Pull requests that update Rust code typegate

Comments

@Yohe-Am
Copy link
Contributor

Yohe-Am commented Feb 7, 2024

Some of the logs/traces emitted seem very adhoc. They contain very little context info and what ought to be trace level logs being present in debug prove a challenge to debugging.

Edit: worst offenders seem to be the ones present in the typescript section of the typegate. The rust logs have the function's type_path.

A general improvement in instrumentation and maybe OpenTelemetry for the typegate seems like a good idea. Instrumenting a large code-base in general is a bit daunting so best to start picking away at the mountain early.

Consider moving from the log crates to the tracing as well as they have better mind share/more features for otel and whatnot.

@Yohe-Am Yohe-Am added enhancement New feature or request meta-cli typegate pr:rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Feb 7, 2024
Copy link

linear bot commented Feb 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code meta-cli pr:rust Pull requests that update Rust code typegate
Projects
None yet
Development

No branches or pull requests

1 participant