Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching Meteor binaries #8

Open
jankapunkt opened this issue Mar 17, 2020 · 2 comments
Open

Caching Meteor binaries #8

jankapunkt opened this issue Mar 17, 2020 · 2 comments

Comments

@jankapunkt
Copy link

Thank you for this great package. I am still new to Actions and tried to find out, if this action already caches the Meteor install as I think it is a bit overkill for every push and pr to install the Meteor binary again.

If this is not currently supported, do you think it would be feasible to add this feature and maybe a flag to the config like cache: true?

@mpowaga
Copy link
Contributor

mpowaga commented Mar 18, 2020

It is not cached. I don't think there is significant difference in speed between downloading a tarball and decompressing it vs downloading uncompressed binaries. Meteor installation takes less than 20 seconds (check this build) so even if we make it 50% faster it won't make much difference.

However if someone doesn't want to overload Meteor's CDN and use its own cache instead then it would make sense to add this option.

@mpowaga
Copy link
Contributor

mpowaga commented Mar 23, 2020

Just checked windows build and it takes 4 minutes to setup Meteor. So it might be worth adding this option for windows at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants