Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks velocity meteor-cucumber #10

Open
geekyme opened this issue Apr 1, 2015 · 5 comments
Open

Breaks velocity meteor-cucumber #10

geekyme opened this issue Apr 1, 2015 · 5 comments
Labels

Comments

@geekyme
Copy link

geekyme commented Apr 1, 2015

Hey there, great work on this package.
One minor problem though... when my meteor app (with its test suite) is first started, everything ran fine - my tests run and everything passed as expected.

However, when I make an edit to my cucumber step files and save, eg.

this.Given(/blah$/, function (callback) {
    helper.world.browser
      .url(helper.world.mirrorUrl)
      .executeAsync(function(done){
        Meteor.loginWithPassword('testuser1', 'testpassword', function(err){
          done(err || true)
        });
      }, function(err, ret){
        assert.deepEqual(true, ret.value);
      })
      .call(callback)
  });

My cucumber log (from .meteor/local/log/cucumber.log) shows this

[velocity-mirror] Mirror is initializing...
The package alanning:package-stubber at 0.0.15 is incompatible with Meteor 0.9.0 or later. 
If a new, compatible version of this package exists, running 'meteor update' should cause you to update. 
Sikka: starting with these configurations: {"captcha":{"siteKey":"xxx","secret":"xxx"},"rateLimits":{"perIp":20,"perHuman":20,"perSession":20},"times":{"blockIpFor":120000,"humanLivesUpto":3600000},"onlyForHumans":false}
LISTENING
[velocity-mirror] Mirror is ready.
Sikka: IP Blocked. 127.0.0.1
Sikka: Closing current connection 5Bw7wJMxiAiFk6d8t

@arunoda
Copy link
Member

arunoda commented Apr 1, 2015

Okay. May be we need to add a feature to disable Sikka locally or detect
velocity and block it.

On Wed, Apr 1, 2015 at 6:12 AM Shawn Lim [email protected] wrote:

Hey there, great work on this package.
One minor problem though... when my meteor app (with its test suite) is
first started, everything ran fine - my tests run and everything passed as
expected.

However, when I make an edit to my cucumber step files and save, eg.

this.Given(/blah$/, function (callback) {
helper.world.browser
.url(helper.world.mirrorUrl)
.executeAsync(function(done){
Meteor.loginWithPassword('testuser1', 'testpassword', function(err){
done(err || true)
});
}, function(err, ret){
assert.deepEqual(true, ret.value);
})
.call(callback)
});

My cucumber log (from .meteor/local/log/cucumber.log) shows this

[velocity-mirror] Mirror is initializing...
The package alanning:package-stubber at 0.0.15 is incompatible with Meteor 0.9.0 or later.
If a new, compatible version of this package exists, running 'meteor update' should cause you to update.
Sikka: starting with these configurations: {"captcha":{"siteKey":"xxx","secret":"xxx"},"rateLimits":{"perIp":20,"perHuman":20,"perSession":20},"times":{"blockIpFor":120000,"humanLivesUpto":3600000},"onlyForHumans":false}
LISTENING
[velocity-mirror] Mirror is ready.
Sikka: IP Blocked. 127.0.0.1
Sikka: Closing current connection 5Bw7wJMxiAiFk6d8t


Reply to this email directly or view it on GitHub
#10.

@arunoda
Copy link
Member

arunoda commented Apr 1, 2015

@samhatoum any ways to determine whether the meteor process is a velocity mirror or not?

@arunoda arunoda added the bug label Apr 1, 2015
@samhatoum
Copy link

yep, easy. process.env.IS_MIRROR :)

@arunoda
Copy link
Member

arunoda commented Apr 1, 2015

Nice. Thanks.
On 2015 අප්‍රේල් 1, බදාදා at පෙ.ව. 7.16 Sam Hatoum [email protected]
wrote:

yep, easy. process.env.IS_MIRROR :)


Reply to this email directly or view it on GitHub
#10 (comment).

@geekyme
Copy link
Author

geekyme commented Apr 5, 2015

is there going to be a release to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants