-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on fourseven:scss #1
Comments
+1 :) |
+1 i wanted to use the ruby sass so bad. |
i started converting to stylus but ran into a ton of errors on the autoconverted output not sure if this is one global errors, but fixing this amount of glitches on every upstream pull isn't manageable |
I converted this package and the icon package to stylus: Thanks to @dcsan for the initial work. Issues
Incorrect conversion
Correct conversion
Caveats
Although I tested this with the contacts demo and everything looked great. |
Nice work @koolaid1551! This is a great alternative to the SCSS package(s), I'll add a note to the README. |
this is great @koolaid1551 ! I was using sass2stylus doing manual conversions each time we want to pull upstream will be quite a hassle... |
I did the fixes manually but I was looking into fixing the converter so there wouldn't be a manual conversion each time. At some point I was hoping to submit a pull request to the ionic framework itself. It seems that the Ionic Team might already has its own thoughts of doing this (http://forum.ionicframework.com/t/converting-scss-to-stylus/2277/3). The odd part is that the major issues(i.e. the indent issues and the curly bracket variables) seem to work correctly when going to http://sass2stylus.com/ (https://github.com/paulcpederson/sass2stylus/ is an all ruby fork of https://github.com/mojotech/sass2stylus/). The rest of the issues seem pretty straight forward to fix. However there is going to have to be some code modifications around the Transformation Mixins piece. If ionic is really open to having a stylus port as well, I'm sure they would be open to a little bit of rework in that area. Also I found out that the colors differences can be fixed by removing the percent in the darken and lighten functions, as Stylus has two was of calculating this(which is stated in the docs). Fortunately with or without the percent in sass compute to the same color. Stylus
SASS
|
unfortunately seems they're set on scss |
fourseven:scss
fourseven:scss
andarsnebula:sass
The text was updated successfully, but these errors were encountered: