Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pyaro into pyaerocom #977

Closed
dulte opened this issue Jan 30, 2024 · 10 comments
Closed

Integrate pyaro into pyaerocom #977

dulte opened this issue Jan 30, 2024 · 10 comments
Assignees
Labels
enhancement ✨ New feature or request new-feature
Milestone

Comments

@dulte
Copy link
Collaborator

dulte commented Jan 30, 2024

#976

@dulte dulte added enhancement ✨ New feature or request new-feature labels Jan 30, 2024
@dulte dulte self-assigned this Jan 30, 2024
@dulte dulte added this to the m2024-03 milestone Jan 30, 2024
@dulte
Copy link
Collaborator Author

dulte commented Jan 30, 2024

Pyaerocom can as of this read and colocate pyaro. I've written tests for reading, and is working on tests for colocation

@dulte
Copy link
Collaborator Author

dulte commented Jan 30, 2024

@lewisblake, @heikoklein. I've not made any checks for if the user has made a Pyaro reader that uses the same data id as the one pyaerocom readers. This might cause some error/confusion reading. Should I make such a check, or do we assume that this will not happen? (E.g. by removing all readers internal to pyaerocom)

@lewisblake
Copy link
Member

I would suggest putting a check until we actually have removed all readers internal to pyaerocom (if it does indeed get implemented). Better to put in some safety measures than assume someone knows all of this.

@dulte
Copy link
Collaborator Author

dulte commented Feb 20, 2024

@lewisblake , I've added you as a reviewer to the pyaro interface PR. It is 90% done, so it is a good time to start looking at it. In the comment below I'll add a list over things features I've yet to add

@dulte
Copy link
Collaborator Author

dulte commented Feb 20, 2024

Metadata to get from Pyaro, if possible. Needed for complete Station metadata:

  • instrument name
  • station_id?
  • filename
  • revision date
  • data level
  • PI

Optimalization

  • Make code faster...

Features to check

  • ts_type (freq)

@heikoklein
Copy link
Member

PI and instrument name are a good extension for pyaro station-metadata.
filename make no sense in most cases, it is just a way of packing which might not even exist.
Not sure what data level should be.

@dulte
Copy link
Collaborator Author

dulte commented Feb 20, 2024

I've now added code that simply checks if the metadata names above are fields in the Station object. If not it will fill in the same default that readungridded uses (mostly None)

@dulte
Copy link
Collaborator Author

dulte commented Feb 20, 2024

New changes (list of configs) are not yet tested with PyAeroval. I will test this next week. After that the PR should be ready on my side

@dulte
Copy link
Collaborator Author

dulte commented Feb 27, 2024

I've written a couple more tests, and tested the implementation with pyaeroval. Everything seems to work, and the tests passes. There will guaranteed be more bugs, I've yet to find them... So as of now, I think the implementation is ready

@dulte
Copy link
Collaborator Author

dulte commented Feb 27, 2024

Now merged

@dulte dulte closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request new-feature
Projects
None yet
Development

No branches or pull requests

3 participants