-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate pyaro into pyaerocom #977
Comments
Pyaerocom can as of this read and colocate pyaro. I've written tests for reading, and is working on tests for colocation |
@lewisblake, @heikoklein. I've not made any checks for if the user has made a Pyaro reader that uses the same data id as the one pyaerocom readers. This might cause some error/confusion reading. Should I make such a check, or do we assume that this will not happen? (E.g. by removing all readers internal to pyaerocom) |
I would suggest putting a check until we actually have removed all readers internal to pyaerocom (if it does indeed get implemented). Better to put in some safety measures than assume someone knows all of this. |
@lewisblake , I've added you as a reviewer to the pyaro interface PR. It is 90% done, so it is a good time to start looking at it. In the comment below I'll add a list over things features I've yet to add |
Metadata to get from Pyaro, if possible. Needed for complete Station metadata:
Optimalization
Features to check
|
PI and instrument name are a good extension for pyaro station-metadata. |
I've now added code that simply checks if the metadata names above are fields in the Station object. If not it will fill in the same default that readungridded uses (mostly None) |
New changes (list of configs) are not yet tested with PyAeroval. I will test this next week. After that the PR should be ready on my side |
I've written a couple more tests, and tested the implementation with pyaeroval. Everything seems to work, and the tests passes. There will guaranteed be more bugs, I've yet to find them... So as of now, I think the implementation is ready |
Now merged |
#976
The text was updated successfully, but these errors were encountered: