Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary profile processing code cleanup #560

Closed
3 tasks done
akvlad opened this issue Aug 31, 2024 · 0 comments
Closed
3 tasks done

Binary profile processing code cleanup #560

akvlad opened this issue Aug 31, 2024 · 0 comments

Comments

@akvlad
Copy link
Collaborator

akvlad commented Aug 31, 2024

What

There is a submodule to work with pprof inside the Pyroscope API module: https://github.com/metrico/qryn/tree/master/pyroscope/pprof-bin . As far as it works with binary data at most, it's written in Rust and compiled as a wasm module.

We have to clean the code of the module.

Why

As far as it was the one of the first pieces of Rust code written by its developer, the quality of code can be much better.

Also there may be unoptimized pieces of code with underline memory copy unnoticed.

How

We have to do a set of steps in order to raise the quality of code.

@akvlad akvlad closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant