Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is auto-deletion of Sink data queues a reliable feature? #20

Open
phijor opened this issue Jan 9, 2021 · 0 comments · May be fixed by #46
Open

Is auto-deletion of Sink data queues a reliable feature? #20

phijor opened this issue Jan 9, 2021 · 0 comments · May be fixed by #46
Labels
cleanup Issues related to code cleanup and legacy features question Further information is requested

Comments

@phijor
Copy link
Contributor

phijor commented Jan 9, 2021

Essentially what this comments asks:

metricq-manager/metricq_manager/manager.py

Lines 109 to 110 in 7f96854

# TODO if this proves to be reliable, remove the option
self._subscription_autodelete = True

The option isn't set anywhere else in the code.
@phijor phijor added question Further information is requested cleanup Issues related to code cleanup and legacy features labels Jan 9, 2021
bmario added a commit that referenced this issue Mar 6, 2023
@bmario
fix: remove auto-deletion toggle
1d73295 
It seems highly reliable, so let's remove this.

Fixes #20
@bmario bmario linked a pull request Mar 6, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Issues related to code cleanup and legacy features question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove auto-deletion toggle metricq/metricq-manager
1 participant
@phijor