tweak_initial_estimates: matrix handling #656
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- matrix types are still not set up
- support for diagonal vs block records - support for correlation vs covariance on off-diagonals - support for standard deviation vs variance on diagonals TODO: - look into supporting SAME blocks and other types - unsupported types will need to error out - add tests for all new matrix handling features
- add test that confirms `mod_matrix()` is working as intended thus far
- add more clarity to matrix helpers. There may be interest in exporting a function similar to `mod_matrix` at some point down the line.
- as referred to in `nmrec`: 'vpair' subtypes, or when parameter options represent `VALUES(diag,odiag)` - 'values' subtypes, or when parameter options contain the form `(0.01)x2 0.1` This change pulls in a few internal `nmrec` functions (`matrix_is_vpair`, `param_options`, and a modified version of `param_x`). These functions are pretty simple, and I probably would have developed similar ones on my own if I didnt think to grab them from `nmrec`. That being said, I imagine we will want to pull out some of the functionality `get_matrix_opts` is responsible for, and move it to the `nmrec` side. As of this commit, all concerns mentioned in #640 have been addressed. Additional tests are needed, and the `nmrec`/`bbr` refactor I mentioned above will likely come beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling for matrix-type records. Specifically check for positive-definiteness and include handling for different formats of OMEGA and SIGMA matrices, such as:
VARIANCE(default) orSTANDARDcontrols whether diagonals are taken as variance or standard deviation, respectivelyCOVARIANCE(default) orCORRELATIONcontrols whether the off-diagonals are taken as covariance or correlations, respectivelyCHOLESKYrepresentationsSAMEblocks and records defined like the one below:closes #640