Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgr marks tarball dependencies as "user_defined" #376

Open
Dreznel opened this issue Jul 29, 2021 · 1 comment
Open

Pkgr marks tarball dependencies as "user_defined" #376

Dreznel opened this issue Jul 29, 2021 · 1 comment

Comments

@Dreznel
Copy link
Contributor

Dreznel commented Jul 29, 2021

Found while creating "tarball-install" E2E tests.

ellipsis depends on rlang, but as you'll see in the output, rlang is marked as "user_defined" even though it's not defined in Tarballs or Packages. This might be intentional, but it doesn't seem intuitive.

pkgr.yml:

Version: 1
# top level packages

Tarballs:
  - "./tarballs/ellipsis_0.3.2.tar.gz" # depends on rlang

Packages:
  - crayon

# any repositories, order matters
Repos:
  - LOCALREPO: "./localrepo"

Cache: test-cache

Library: "test-library"

Customizations:
  Repos:
    - LOCALREPO:
        Type: source

image

@Dreznel
Copy link
Contributor Author

Dreznel commented Jul 29, 2021

Looking into the code, this ultimately occurs because we sort of took a shortcut with Tarball dependencies by simply adding them to the list of user-defined packages in the CFG file. The dependencies need to be installed before the tarball installation is attempted, and ensured that that would happen without requiring have pkgr do an entirely separate, "from the ground up" installation procedure for tarballs.

This is causing a test to fail at the moment. I am in favor of simply calling this "expected behavior" and updating the test accordingly until we have a chance to come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant